mrva/vscode-codeql
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Merge pull request #2179 from github/robertbrignull/remove_openVariantAnalysisQueryFile_command

Browse Source 
Remove codeQL.openVariantAnalysisQueryFile command
This commit is contained in:
Robert
2023-03-17 11:23:31 +00:00
committed by GitHub
parent 8a5273058b 29bb7ce01e
commit df24a705b0
5 changed files with 5 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
extensions/ql-vscode/src/extension.ts
View File

@@ -1216,15 +1216,6 @@ async function activateWithInstalledDistribution(
), ),
); );
ctx.subscriptions.push(
commandRunner(
"codeQL.openVariantAnalysisQueryFile",
async (variantAnalysisId: number) => {
await variantAnalysisManager.openQueryFile(variantAnalysisId);
},
),
);
ctx.subscriptions.push( ctx.subscriptions.push(
commandRunner("codeQL.openReferencedFile", async (selectedQuery: Uri) => { commandRunner("codeQL.openReferencedFile", async (selectedQuery: Uri) => {
await openReferencedFile(qs, cliServer, selectedQuery); await openReferencedFile(qs, cliServer, selectedQuery);

3
extensions/ql-vscode/src/query-history/query-history-manager.ts
View File

@@ -528,8 +528,7 @@ export class QueryHistoryManager extends DisposableObject {
} }
if (finalSingleItem.t === "variant-analysis") { if (finalSingleItem.t === "variant-analysis") {
await commands.executeCommand( await this.variantAnalysisManager.openQueryFile(
"codeQL.openVariantAnalysisQueryFile",
finalSingleItem.variantAnalysis.id, finalSingleItem.variantAnalysis.id,
); );
return; return;

1
extensions/ql-vscode/src/variant-analysis/variant-analysis-view-manager.ts
View File

@@ -24,4 +24,5 @@ export interface VariantAnalysisViewManager<
getRepoStates( getRepoStates(
variantAnalysisId: number, variantAnalysisId: number,
): Promise<VariantAnalysisScannedRepositoryState[]>; ): Promise<VariantAnalysisScannedRepositoryState[]>;
openQueryFile(variantAnalysisId: number): Promise<void>;
} }

5
extensions/ql-vscode/src/variant-analysis/variant-analysis-view.ts
View File

@@ -123,10 +123,7 @@ export class VariantAnalysisView
); );
break; break;
case "openQueryFile": case "openQueryFile":
void commands.executeCommand( await this.manager.openQueryFile(this.variantAnalysisId);
"codeQL.openVariantAnalysisQueryFile",
this.variantAnalysisId,
);
break; break;
case "openQueryText": case "openQueryText":
void commands.executeCommand( void commands.executeCommand(

3
extensions/ql-vscode/src/view/variant-analysis/VariantAnalysis.tsx
View File

@@ -13,7 +13,7 @@ import { VariantAnalysisLoading } from "./VariantAnalysisLoading";
import { ToVariantAnalysisMessage } from "../../pure/interface-types"; import { ToVariantAnalysisMessage } from "../../pure/interface-types";
import { vscode } from "../vscode-api"; import { vscode } from "../vscode-api";
import { defaultFilterSortState } from "../../pure/variant-analysis-filter-sort"; import { defaultFilterSortState } from "../../pure/variant-analysis-filter-sort";
import { useTelemetryOnChange } from "../common/telemetry"; import { sendTelemetry, useTelemetryOnChange } from "../common/telemetry";
export type VariantAnalysisProps = { export type VariantAnalysisProps = {
variantAnalysis?: VariantAnalysisDomainModel; variantAnalysis?: VariantAnalysisDomainModel;
@@ -25,6 +25,7 @@ const openQueryFile = () => {
vscode.postMessage({ vscode.postMessage({
t: "openQueryFile", t: "openQueryFile",
}); });
sendTelemetry("variant-analysis-open-query-file");
}; };
const openQueryText = () => { const openQueryText = () => {