From ddf4407c8c2e5ac02de2206f6384ef27d1aa7f00 Mon Sep 17 00:00:00 2001 From: Koen Vlaswinkel Date: Wed, 6 Dec 2023 10:59:25 +0100 Subject: [PATCH] Fix loading message for compare view --- .../ql-vscode/src/view/compare/Compare.tsx | 20 ++++++------------- 1 file changed, 6 insertions(+), 14 deletions(-) diff --git a/extensions/ql-vscode/src/view/compare/Compare.tsx b/extensions/ql-vscode/src/view/compare/Compare.tsx index 57e3fc2bf..50a2d1b9f 100644 --- a/extensions/ql-vscode/src/view/compare/Compare.tsx +++ b/extensions/ql-vscode/src/view/compare/Compare.tsx @@ -11,23 +11,14 @@ import CompareTable from "./CompareTable"; import "../results/resultsView.css"; -const emptyComparison: SetComparisonsMessage = { - t: "setComparisons", - stats: {}, - result: undefined, - commonResultSetNames: [], - currentResultSetName: "", - databaseUri: "", - message: "Empty comparison", -}; - export function Compare(_: Record): JSX.Element { - const [comparison, setComparison] = - useState(emptyComparison); + const [comparison, setComparison] = useState( + null, + ); - const message = comparison.message || "Empty comparison"; + const message = comparison?.message || "Empty comparison"; const hasRows = - comparison.result && + comparison?.result && (comparison.result.to.length || comparison.result.from.length); useEffect(() => { @@ -50,6 +41,7 @@ export function Compare(_: Record): JSX.Element { window.removeEventListener("message", listener); }; }, []); + if (!comparison) { return
Waiting for results to load.
; }