mrva/vscode-codeql
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Consistently check for undefined rather than nullish

Browse Source
This commit is contained in:
Asger F
2022-10-21 14:17:06 +02:00
parent 65777b5e60
commit d4a58a64ee
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
extensions/ql-vscode/src/view/results/alert-table.tsx
View File

@@ -313,19 +313,19 @@ export class PathTable extends React.Component<PathTableProps, PathTableState> {
// Check if the selected node actually exists (bounds check) and get its location if relevant // Check if the selected node actually exists (bounds check) and get its location if relevant
let jumpLocation: Sarif.Location | undefined; let jumpLocation: Sarif.Location | undefined;
if (key.pathNodeIndex != null) { if (key.pathNodeIndex !== undefined) {
jumpLocation = Keys.getPathNode(data, key); jumpLocation = Keys.getPathNode(data, key);
if (jumpLocation == null) { if (jumpLocation === undefined) {
return prevState; // Result does not exist return prevState; // Result does not exist
} }
} else if (key.pathIndex != null) { } else if (key.pathIndex !== undefined) {
if (Keys.getPath(data, key) == null) { if (Keys.getPath(data, key) === undefined) {
return prevState; // Path does not exist return prevState; // Path does not exist
} }
jumpLocation = undefined; // When selecting a 'path', don't jump anywhere. jumpLocation = undefined; // When selecting a 'path', don't jump anywhere.
} else { } else {
jumpLocation = Keys.getResult(data, key)?.locations?.[0]; jumpLocation = Keys.getResult(data, key)?.locations?.[0];
if (jumpLocation == null) { if (jumpLocation === undefined) {
return prevState; // Path step does not exist. return prevState; // Path step does not exist.
} }
} }