mrva/vscode-codeql
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Fix comment to be more accurate

Browse Source
This commit is contained in:
Robert
2023-05-30 15:11:39 +01:00
parent 82766d1033
commit d2bb1b844e
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
extensions/ql-vscode/src/common/discovery.ts
View File

@@ -8,7 +8,7 @@ import { getErrorMessage } from "../pure/helpers-pure";
* same time. * same time.
*/ */
export abstract class Discovery<T> extends DisposableObject { export abstract class Discovery<T> extends DisposableObject {
private retry = false; private restartWhenFinished = false;
private currentDiscoveryPromise: Promise<void> | undefined; private currentDiscoveryPromise: Promise<void> | undefined;
constructor(private readonly name: string) { constructor(private readonly name: string) {
@@ -48,7 +48,7 @@ export abstract class Discovery<T> extends DisposableObject {
if (this.currentDiscoveryPromise !== undefined) { if (this.currentDiscoveryPromise !== undefined) {
// There's already a discovery operation in progress. Tell it to restart when it's done. // There's already a discovery operation in progress. Tell it to restart when it's done.
this.retry = true; this.restartWhenFinished = true;
} else { } else {
// No discovery in progress, so start one now. // No discovery in progress, so start one now.
this.currentDiscoveryPromise = this.launchDiscovery(); this.currentDiscoveryPromise = this.launchDiscovery();
@@ -72,13 +72,13 @@ export abstract class Discovery<T> extends DisposableObject {
results = undefined; results = undefined;
} }
if (this.retry) { if (this.restartWhenFinished) {
// Another refresh request came in while we were still running a previous discovery // Another refresh request came in while we were still running a previous discovery
// operation. Since the discovery results we just computed are now stale, we'll launch // operation. Since the discovery results we just computed are now stale, we'll launch
// another discovery operation instead of updating. // another discovery operation instead of updating.
// Note that by doing this inside of `finally`, we will relaunch discovery even if the // We want to relaunch discovery regardless of if the initial discovery operation
// initial discovery operation failed. // succeeded or failed.
this.retry = false; this.restartWhenFinished = false;
await this.launchDiscovery(); await this.launchDiscovery();
} else { } else {
this.currentDiscoveryPromise = undefined; this.currentDiscoveryPromise = undefined;