From d173ff3c48424921596496d1d8bf6e4f7db80381 Mon Sep 17 00:00:00 2001 From: Robert Date: Fri, 11 Aug 2023 17:22:21 +0100 Subject: [PATCH] Convert vscodeMessageHandler to use useCallback --- .../ql-vscode/src/view/results/ResultTables.tsx | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/extensions/ql-vscode/src/view/results/ResultTables.tsx b/extensions/ql-vscode/src/view/results/ResultTables.tsx index 66c2f2af2..c153f498e 100644 --- a/extensions/ql-vscode/src/view/results/ResultTables.tsx +++ b/extensions/ql-vscode/src/view/results/ResultTables.tsx @@ -145,13 +145,16 @@ export function ResultTables(props: ResultTablesProps) { } }, []); - const vscodeMessageHandler = (evt: MessageEvent): void => { - // sanitize origin - const origin = evt.origin.replace(/\n|\r/g, ""); - evt.origin === window.origin - ? handleMessage(evt.data as IntoResultsViewMsg) - : console.error(`Invalid event origin ${origin}`); - }; + const vscodeMessageHandler = useCallback( + (evt: MessageEvent): void => { + // sanitize origin + const origin = evt.origin.replace(/\n|\r/g, ""); + evt.origin === window.origin + ? handleMessage(evt.data as IntoResultsViewMsg) + : console.error(`Invalid event origin ${origin}`); + }, + [handleMessage], + ); // TODO: Duplicated from results.tsx consider a way to // avoid this duplication