From cff7170fdc65f0818542f955e940c628f5418545 Mon Sep 17 00:00:00 2001 From: Robert Date: Wed, 16 Aug 2023 10:52:26 +0100 Subject: [PATCH] Move AlertTableTruncatedMessage to a new component in a new file --- .../ql-vscode/src/view/results/AlertTable.tsx | 19 +++++++------------ .../results/AlertTableTruncatedMessage.tsx | 19 +++++++++++++++++++ 2 files changed, 26 insertions(+), 12 deletions(-) create mode 100644 extensions/ql-vscode/src/view/results/AlertTableTruncatedMessage.tsx diff --git a/extensions/ql-vscode/src/view/results/AlertTable.tsx b/extensions/ql-vscode/src/view/results/AlertTable.tsx index ecac4c832..4666f21e0 100644 --- a/extensions/ql-vscode/src/view/results/AlertTable.tsx +++ b/extensions/ql-vscode/src/view/results/AlertTable.tsx @@ -23,6 +23,7 @@ import { SarifMessageWithLocations } from "./locations/SarifMessageWithLocations import { SarifLocation } from "./locations/SarifLocation"; import { AlertTableDropdownIndicatorCell } from "./AlertTableDropdownIndicatorCell"; import { AlertTableNoResults } from "./AlertTableNoResults"; +import { AlertTableTruncatedMessage } from "./AlertTableTruncatedMessage"; type AlertTableProps = ResultTableProps & { resultSet: InterpretedResultSet; @@ -295,21 +296,15 @@ export class AlertTable extends React.Component< }, ); - if (numTruncatedResults > 0) { - rows.push( - - - Too many results to show at once. {numTruncatedResults} result(s) - omitted. - - , - ); - } - return ( - {rows} + + {rows} + +
); } diff --git a/extensions/ql-vscode/src/view/results/AlertTableTruncatedMessage.tsx b/extensions/ql-vscode/src/view/results/AlertTableTruncatedMessage.tsx new file mode 100644 index 000000000..58acb7d7d --- /dev/null +++ b/extensions/ql-vscode/src/view/results/AlertTableTruncatedMessage.tsx @@ -0,0 +1,19 @@ +import * as React from "react"; + +interface Props { + numTruncatedResults: number; +} + +export function AlertTableTruncatedMessage(props: Props): JSX.Element | null { + if (props.numTruncatedResults === 0) { + return null; + } + return ( + + + Too many results to show at once. {props.numTruncatedResults} result(s) + omitted. + + + ); +}