Apply suggestions from code review
Co-authored-by: Koen Vlaswinkel <koesie10@users.noreply.github.com>
This commit is contained in:
committed by
GitHub
parent
d2b17e1676
commit
cc3feabe66
@@ -13,7 +13,7 @@ import {
|
|||||||
} from "../common/query-language";
|
} from "../common/query-language";
|
||||||
|
|
||||||
const ALL_LANGUAGE_SELECTION_OPTIONS = [
|
const ALL_LANGUAGE_SELECTION_OPTIONS = [
|
||||||
undefined, // All langauges
|
undefined, // All languages
|
||||||
QueryLanguage.Cpp,
|
QueryLanguage.Cpp,
|
||||||
QueryLanguage.CSharp,
|
QueryLanguage.CSharp,
|
||||||
QueryLanguage.Go,
|
QueryLanguage.Go,
|
||||||
@@ -24,7 +24,7 @@ const ALL_LANGUAGE_SELECTION_OPTIONS = [
|
|||||||
QueryLanguage.Swift,
|
QueryLanguage.Swift,
|
||||||
];
|
];
|
||||||
|
|
||||||
// A tree view items consisting of of a language (or undefined for all languages
|
// A tree view items consisting of of a language (or undefined for all languages)
|
||||||
// and a boolean indicating whether it is selected or not.
|
// and a boolean indicating whether it is selected or not.
|
||||||
export class LanguageSelectionTreeViewItem extends TreeItem {
|
export class LanguageSelectionTreeViewItem extends TreeItem {
|
||||||
constructor(
|
constructor(
|
||||||
|
|||||||
@@ -57,7 +57,7 @@ describe("LanguageSelectionTreeDataProvider", () => {
|
|||||||
expectSelected(items, undefined);
|
expectSelected(items, undefined);
|
||||||
});
|
});
|
||||||
|
|
||||||
it("When language is changed then the selected element change", async () => {
|
it("When language is changed then the selected element changes", async () => {
|
||||||
await languageContext.setLanguageContext(QueryLanguage.CSharp);
|
await languageContext.setLanguageContext(QueryLanguage.CSharp);
|
||||||
const items = dataProvider.getChildren();
|
const items = dataProvider.getChildren();
|
||||||
expectSelected(items, QueryLanguage.CSharp);
|
expectSelected(items, QueryLanguage.CSharp);
|
||||||
|
|||||||
Reference in New Issue
Block a user