From c34c9fae6aac76ebfe0cb94956111a303e8fbad9 Mon Sep 17 00:00:00 2001 From: Andrew Eisenberg Date: Tue, 29 Sep 2020 14:58:16 -0700 Subject: [PATCH] Avoid using path.join for sarif uris These are uris, not paths and always use '/', even on windows. --- extensions/ql-vscode/src/sarif-utils.ts | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/extensions/ql-vscode/src/sarif-utils.ts b/extensions/ql-vscode/src/sarif-utils.ts index 2dc7a3de2..81ec1dce8 100644 --- a/extensions/ql-vscode/src/sarif-utils.ts +++ b/extensions/ql-vscode/src/sarif-utils.ts @@ -1,5 +1,4 @@ import * as Sarif from 'sarif'; -import * as path from 'path'; import { ResolvableLocationValue } from './bqrs-cli-types'; export interface SarifLink { @@ -74,9 +73,7 @@ export function getPathRelativeToSourceLocationPrefix( sarifRelativeUri: string ) { const normalizedSourceLocationPrefix = sourceLocationPrefix.replace(/\\/g, '/'); - return `file:${ - path.join(normalizedSourceLocationPrefix, sarifRelativeUri) - }`; + return `file:${normalizedSourceLocationPrefix}/${sarifRelativeUri}`; } export function parseSarifLocation(