From c2b2d10591835d8d3481b2c22b8607caabfe8c59 Mon Sep 17 00:00:00 2001 From: Michael Hohn Date: Sat, 15 Mar 2025 17:43:14 -0700 Subject: [PATCH] refactor cli --- extensions/ql-vscode/src/codeql-cli/cli.ts | 22 +++++++--------------- 1 file changed, 7 insertions(+), 15 deletions(-) diff --git a/extensions/ql-vscode/src/codeql-cli/cli.ts b/extensions/ql-vscode/src/codeql-cli/cli.ts index 82785e0db..9aae67ea8 100644 --- a/extensions/ql-vscode/src/codeql-cli/cli.ts +++ b/extensions/ql-vscode/src/codeql-cli/cli.ts @@ -96,10 +96,8 @@ export interface CompilationMessage { severity: CompilationMessageSeverity; // Error or Warning } -/** - * Event fired by `codeql test run`. - */ export interface TestCompleted { + // Event fired by `codeql test run` test: string; pass: boolean; messages: CompilationMessage[]; @@ -107,29 +105,23 @@ export interface TestCompleted { evaluationMs: number; expected: string; actual?: string; - diff: string[] | undefined; + diff?: string[]; failureDescription?: string; failureStage?: string; } -/** - * Optional arguments for the `bqrsDecode` function - */ interface BqrsDecodeOptions { - /** How many results to get. */ - pageSize?: number; - /** The 0-based index of the first result to get. */ - offset?: number; - /** The entity names to retrieve from the bqrs file. Default is url, string */ - entities?: string[]; + // Optional arguments for `bqrsDecode` + pageSize?: number; // Number of results to retrieve + offset?: number; // 0-based index of the first result + entities?: string[]; // Default: ["url", "string"] } type OnLineCallback = ( line: string, ) => Promise | string | undefined; - type VersionChangedListener = ( - newVersionAndFeatures: VersionAndFeatures | undefined, + newVersionAndFeatures?: VersionAndFeatures, ) => void; type RunOptions = {