From 37cf525c8e4b4450021086f04170fe21ece289d2 Mon Sep 17 00:00:00 2001 From: Jason Reed Date: Fri, 14 Aug 2020 08:06:31 -0400 Subject: [PATCH 1/2] Fix changing page forgetting about sorting --- extensions/ql-vscode/src/interface.ts | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/extensions/ql-vscode/src/interface.ts b/extensions/ql-vscode/src/interface.ts index 22b645f36..288308ba5 100644 --- a/extensions/ql-vscode/src/interface.ts +++ b/extensions/ql-vscode/src/interface.ts @@ -270,7 +270,15 @@ export class InterfaceManager extends DisposableObject { await this.showPageOfInterpretedResults(msg.pageNumber); } else { - await this.showPageOfRawResults(msg.selectedTable, msg.pageNumber); + await this.showPageOfRawResults( + msg.selectedTable, + msg.pageNumber, + // When we are in an unsorted state, we guarantee that + // sortedResultsInfo doesn't have an entry for the current + // result set. Use this to determine whether or not we use + // the sorted bqrs file. + this._displayedQuery?.sortedResultsInfo.has(msg.selectedTable) || false + ); } break; default: From 518e6c14cc91758b933db75530c849e46f2b6a4d Mon Sep 17 00:00:00 2001 From: Jason Reed Date: Fri, 14 Aug 2020 08:09:28 -0400 Subject: [PATCH 2/2] Add changelog entry --- extensions/ql-vscode/CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/extensions/ql-vscode/CHANGELOG.md b/extensions/ql-vscode/CHANGELOG.md index 8d3ce2869..4bbc3d7ed 100644 --- a/extensions/ql-vscode/CHANGELOG.md +++ b/extensions/ql-vscode/CHANGELOG.md @@ -3,6 +3,7 @@ ## 1.3.3 - [UNRELEASED] - Fix display of raw results entities with label but no url. +- Fix bug where sort order is forgotten when changing raw results page ## 1.3.2 - 12 August 2020