mrva/vscode-codeql
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Merge pull request #3183 from github/robertbrignull/remove_releases_repo_config

Browse Source 
Remove ownerName and repositoryName from DistributionConfig
This commit is contained in:
Robert
2024-01-03 09:46:45 +00:00
committed by GitHub
parent 1ad20fa354 b082455604
commit b27d8a1000
2 changed files with 2 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
extensions/ql-vscode/src/codeql-cli/distribution.ts
View File

@@ -512,9 +512,7 @@ class ExtensionSpecificDistributionManager {
} }
private get distributionOwnerName(): string { private get distributionOwnerName(): string {
if (this.config.ownerName) { if (this.config.channel === "nightly") {
return this.config.ownerName;
} else if (this.config.channel === "nightly") {
return NIGHTLY_DISTRIBUTION_OWNER_NAME; return NIGHTLY_DISTRIBUTION_OWNER_NAME;
} else { } else {
return DEFAULT_DISTRIBUTION_OWNER_NAME; return DEFAULT_DISTRIBUTION_OWNER_NAME;
@@ -522,9 +520,7 @@ class ExtensionSpecificDistributionManager {
} }
private get distributionRepositoryName(): string { private get distributionRepositoryName(): string {
if (this.config.repositoryName) { if (this.config.channel === "nightly") {
return this.config.repositoryName;
} else if (this.config.channel === "nightly") {
return NIGHTLY_DISTRIBUTION_REPOSITORY_NAME; return NIGHTLY_DISTRIBUTION_REPOSITORY_NAME;
} else { } else {
return DEFAULT_DISTRIBUTION_REPOSITORY_NAME; return DEFAULT_DISTRIBUTION_REPOSITORY_NAME;

2
extensions/ql-vscode/src/config.ts
View File

@@ -119,8 +119,6 @@ export interface DistributionConfig {
updateCustomCodeQlPath: (newPath: string | undefined) => Promise<void>; updateCustomCodeQlPath: (newPath: string | undefined) => Promise<void>;
includePrerelease: boolean; includePrerelease: boolean;
personalAccessToken?: string; personalAccessToken?: string;
ownerName?: string;
repositoryName?: string;
channel: CLIChannel; channel: CLIChannel;
onDidChangeConfiguration?: Event<void>; onDidChangeConfiguration?: Event<void>;
} }