From afe3c56ca8015cc4fb9cacb2fbb974be550225a7 Mon Sep 17 00:00:00 2001 From: Andrew Eisenberg Date: Mon, 24 Jan 2022 09:30:00 -0800 Subject: [PATCH] Update changelog --- extensions/ql-vscode/CHANGELOG.md | 1 + .../vscode-tests/no-workspace/query-history.test.ts | 10 +++------- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/extensions/ql-vscode/CHANGELOG.md b/extensions/ql-vscode/CHANGELOG.md index 83ad55003..ed905bedf 100644 --- a/extensions/ql-vscode/CHANGELOG.md +++ b/extensions/ql-vscode/CHANGELOG.md @@ -6,6 +6,7 @@ - Fix a bug where the results view moved column even when it was already visible. [#1070](https://github.com/github/vscode-codeql/pull/1070) - Add packaging-related commands. _CodeQL: Download Packs_ downloads query packs from the package registry that can be run locally, and _CodeQL: Install Pack Dependencies_ installs dependencies for packs in your workspace. [#1076](https://github.com/github/vscode-codeql/pull/1076) +- Add query history items as soon as a query is run, including new icons for each history item. [#1094](https://github.com/github/vscode-codeql/pull/1094) ## 1.5.9 - 17 December 2021 diff --git a/extensions/ql-vscode/src/vscode-tests/no-workspace/query-history.test.ts b/extensions/ql-vscode/src/vscode-tests/no-workspace/query-history.test.ts index 9513967fe..84e1017d5 100644 --- a/extensions/ql-vscode/src/vscode-tests/no-workspace/query-history.test.ts +++ b/extensions/ql-vscode/src/vscode-tests/no-workspace/query-history.test.ts @@ -318,18 +318,14 @@ describe('query-history', () => { }); expect(treeItem.label).to.contain('hucairz'); expect(treeItem.contextValue).to.eq('rawResultsItem'); - expect(treeItem.iconPath).to.deep.eq({ - id: 'check', color: undefined - }); + expect(treeItem.iconPath).to.deep.eq(vscode.Uri.file('/a/b/c/media/drive.svg').fsPath); }); it('should get a tree item with interpreted results', async () => { const mockQuery = createMockFullQueryInfo('a', createMockQueryWithResults(true, /* interpreted results */ true)); const treeItem = await historyTreeDataProvider.getTreeItem(mockQuery); expect(treeItem.contextValue).to.eq('interpretedResultsItem'); - expect(treeItem.iconPath).to.deep.eq({ - id: 'check', color: undefined - }); + expect(treeItem.iconPath).to.deep.eq(vscode.Uri.file('/a/b/c/media/drive.svg').fsPath); }); it('should get a tree item that did not complete successfully', async () => { @@ -348,7 +344,7 @@ describe('query-history', () => { const mockQuery = createMockFullQueryInfo('a'); const treeItem = await historyTreeDataProvider.getTreeItem(mockQuery); expect(treeItem.iconPath).to.deep.eq({ - id: 'search-refresh', color: undefined + id: 'sync~spin', color: undefined }); });