Merge pull request #3060 from github/robertbrignull/noUnusedParameters

Enable noUnusedParameters for the view code

extensions/ql-vscode/src/view/common/DeterminateProgressRing.tsx

@@ -3,7 +3,6 @@ import { styled } from "styled-components";
 
 type Props = {
   percent: number;
-  label?: string;
 };
 
 const Circle = styled.div`
@@ -33,10 +32,7 @@ const progressSegments = 44;
 // See https://github.com/microsoft/fast/blob/21c210f2164c5cf285cade1a328460c67e4b97e6/packages/web-components/fast-foundation/src/progress-ring/progress-ring.template.ts
 // Once the determinate progress ring is available in the VSCode webview UI toolkit, we should use that instead
 
-export const DeterminateProgressRing = ({
+export const DeterminateProgressRing = ({ percent }: Props) => (
-  percent,
-  label = "Loading...",
-}: Props) => (
   <Circle
     role="progressbar"
     aria-valuemin={0}

extensions/ql-vscode/src/view/model-editor/LibraryRow.tsx

@@ -226,7 +226,6 @@ export const LibraryRow = ({
         <>
           <SectionDivider />
           <ModeledMethodDataGrid
-            packageName={title}
             methods={methods}
             modeledMethodsMap={modeledMethodsMap}
             modifiedSignatures={modifiedSignatures}

extensions/ql-vscode/src/view/model-editor/ModeledMethodDataGrid.tsx

@@ -15,7 +15,6 @@ export const MULTIPLE_MODELS_GRID_TEMPLATE_COLUMNS =
   "0.5fr 0.125fr 0.125fr 0.125fr 0.125fr max-content";
 
 export type ModeledMethodDataGridProps = {
-  packageName: string;
   methods: Method[];
   modeledMethodsMap: Record<string, ModeledMethod[]>;
   modifiedSignatures: Set<string>;
@@ -27,7 +26,6 @@ export type ModeledMethodDataGridProps = {
 };
 
 export const ModeledMethodDataGrid = ({
-  packageName,
   methods,
   modeledMethodsMap,
   modifiedSignatures,
@@ -81,24 +79,22 @@ export const ModeledMethodDataGrid = ({
               <ScreenReaderOnly>Add or remove models</ScreenReaderOnly>
             </DataGridCell>
           )}
-          {methodsWithModelability.map(
+          {methodsWithModelability.map(({ method, methodCanBeModeled }) => {
-            ({ method, methodCanBeModeled }, index) => {
+            const modeledMethods = modeledMethodsMap[method.signature] ?? [];
-              const modeledMethods = modeledMethodsMap[method.signature] ?? [];
+            return (
-              return (
+              <MethodRow
-                <MethodRow
+                key={method.signature}
-                  key={method.signature}
+                method={method}
-                  method={method}
+                methodCanBeModeled={methodCanBeModeled}
-                  methodCanBeModeled={methodCanBeModeled}
+                modeledMethods={modeledMethods}
-                  modeledMethods={modeledMethods}
+                methodIsUnsaved={modifiedSignatures.has(method.signature)}
-                  methodIsUnsaved={modifiedSignatures.has(method.signature)}
+                modelingInProgress={inProgressMethods.has(method.signature)}
-                  modelingInProgress={inProgressMethods.has(method.signature)}
+                viewState={viewState}
-                  viewState={viewState}
+                revealedMethodSignature={revealedMethodSignature}
-                  revealedMethodSignature={revealedMethodSignature}
+                onChange={onChange}
-                  onChange={onChange}
+              />
-                />
+            );
-              );
+          })}
-            },
-          )}
         </>
       )}
       <HiddenMethodsRow

extensions/ql-vscode/src/view/model-editor/__tests__/ModeledMethodDataGrid.spec.tsx

@@ -45,7 +45,6 @@ describe(ModeledMethodDataGrid.name, () => {
   const render = (props: Partial<ModeledMethodDataGridProps> = {}) =>
     reactRender(
       <ModeledMethodDataGrid
-        packageName="sql2o"
         methods={[method1, method2, method3]}
         modeledMethodsMap={{
           [method1.signature]: [

extensions/ql-vscode/src/view/results/Graph.tsx

@@ -47,9 +47,7 @@ export function Graph({ graphData, databaseUri }: GraphProps) {
             d.attributes["xlink:href"] = "#";
             d.attributes["href"] = "#";
             loc.uri = `file://${loc.uri}`;
-            select(this).on("click", function (e) {
+            select(this).on("click", () => jumpToLocation(loc, databaseUri));
-              jumpToLocation(loc, databaseUri);
-            });
           }
         }
         if ("fill" in d.attributes) {

extensions/ql-vscode/src/view/results/locations/ClickableLocation.tsx

@@ -9,7 +9,6 @@ interface Props {
   loc: ResolvableLocationValue;
   label: string;
   databaseUri: string;
-  title?: string;
   onClick?: () => void;
 }
 
@@ -24,7 +23,6 @@ export function ClickableLocation({
   loc,
   label,
   databaseUri,
-  title,
   onClick: onClick,
 }: Props): JSX.Element {
   const handleClick = useCallback(

extensions/ql-vscode/src/view/results/locations/Location.tsx

@@ -48,7 +48,6 @@ export function Location({
       loc={resolvableLoc}
       label={displayLabel}
       databaseUri={databaseUri}
-      title={title}
       onClick={onClick}
     />
   );

extensions/ql-vscode/src/view/tsconfig.json

@@ -10,6 +10,7 @@
     "rootDir": "../..",
     "strict": true,
     "noUnusedLocals": true,
+    "noUnusedParameters": true,
     "noImplicitReturns": true,
     "noFallthroughCasesInSwitch": true,
     "experimentalDecorators": true,