mrva/vscode-codeql
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Handle undefined URLs

Browse Source
This commit is contained in:
shati-patel
2022-06-01 12:17:00 +01:00
committed by Shati Patel
parent e8348ac12a
commit a78eef464b
2 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
extensions/ql-vscode/src/remote-queries/remote-queries-markdown-generation.ts
View File

@@ -260,7 +260,11 @@ function generateMarkdownForRawTableCell(
case 'object': case 'object':
{ {
const url = tryGetRemoteLocation(value.url, fileLinkPrefix, sourceLocationPrefix); const url = tryGetRemoteLocation(value.url, fileLinkPrefix, sourceLocationPrefix);
cellValue = `[\`${convertNonPrintableChars(value.label)}\`](${url})`; if (url) {
cellValue = `[\`${convertNonPrintableChars(value.label)}\`](${url})`;
} else {
cellValue = `\`${convertNonPrintableChars(value.label)}\``;
}
} }
break; break;
} }

6
extensions/ql-vscode/src/remote-queries/view/RawResultsTable.tsx
View File

@@ -48,7 +48,11 @@ const Cell = ({
return <span>{convertNonPrintableChars(value.toString())}</span>; return <span>{convertNonPrintableChars(value.toString())}</span>;
case 'object': { case 'object': {
const url = tryGetRemoteLocation(value.url, fileLinkPrefix, sourceLocationPrefix); const url = tryGetRemoteLocation(value.url, fileLinkPrefix, sourceLocationPrefix);
return <Link href={url}>{convertNonPrintableChars(value.label)}</Link>; if (url) {
return <Link href={url}>{convertNonPrintableChars(value.label)}</Link>;
} else {
return <span>{convertNonPrintableChars(value.label)}</span>;
}
} }
} }
}; };