MRVA: Expand path results individually
This commit is contained in:
@@ -178,10 +178,12 @@ function generateMarkdownForPathResults(
|
|||||||
interpretedResult: AnalysisAlert,
|
interpretedResult: AnalysisAlert,
|
||||||
language: string
|
language: string
|
||||||
): MarkdownFile {
|
): MarkdownFile {
|
||||||
const pathLines: MarkdownFile = [];
|
const lines: MarkdownFile = [];
|
||||||
|
lines.push('#### Paths', '');
|
||||||
for (const codeFlow of interpretedResult.codeFlows) {
|
for (const codeFlow of interpretedResult.codeFlows) {
|
||||||
|
const pathLines: MarkdownFile = [];
|
||||||
const stepCount = codeFlow.threadFlows.length;
|
const stepCount = codeFlow.threadFlows.length;
|
||||||
pathLines.push(`#### Path with ${stepCount} steps`);
|
const title = `Path with ${stepCount} steps`;
|
||||||
for (let i = 0; i < stepCount; i++) {
|
for (let i = 0; i < stepCount; i++) {
|
||||||
const threadFlow = codeFlow.threadFlows[i];
|
const threadFlow = codeFlow.threadFlows[i];
|
||||||
const link = createMarkdownRemoteFileRef(
|
const link = createMarkdownRemoteFileRef(
|
||||||
@@ -198,8 +200,11 @@ function generateMarkdownForPathResults(
|
|||||||
const codeSnippetIndented = codeSnippet.map((line) => ` ${line}`);
|
const codeSnippetIndented = codeSnippet.map((line) => ` ${line}`);
|
||||||
pathLines.push(`${i + 1}. ${link}`, ...codeSnippetIndented);
|
pathLines.push(`${i + 1}. ${link}`, ...codeSnippetIndented);
|
||||||
}
|
}
|
||||||
|
lines.push(
|
||||||
|
...buildExpandableMarkdownSection(title, pathLines)
|
||||||
|
);
|
||||||
}
|
}
|
||||||
return buildExpandableMarkdownSection('Show paths', pathLines);
|
return lines;
|
||||||
}
|
}
|
||||||
|
|
||||||
function generateMarkdownForRawResults(
|
function generateMarkdownForRawResults(
|
||||||
|
|||||||
@@ -10,10 +10,11 @@
|
|||||||
|
|
||||||
*This shell command depends on an uncontrolled [absolute path](https://github.com/github/codeql/blob/48015e5a2e6202131f2d1062cc066dc33ed69a9b/javascript/ql/src/Security/CWE-078/examples/shell-command-injection-from-environment.js#L4-L4).*
|
*This shell command depends on an uncontrolled [absolute path](https://github.com/github/codeql/blob/48015e5a2e6202131f2d1062cc066dc33ed69a9b/javascript/ql/src/Security/CWE-078/examples/shell-command-injection-from-environment.js#L4-L4).*
|
||||||
|
|
||||||
<details>
|
#### Paths
|
||||||
<summary>Show paths</summary>
|
|
||||||
|
<details>
|
||||||
|
<summary>Path with 5 steps</summary>
|
||||||
|
|
||||||
#### Path with 5 steps
|
|
||||||
1. [javascript/ql/src/Security/CWE-078/examples/shell-command-injection-from-environment.js](https://github.com/github/codeql/blob/48015e5a2e6202131f2d1062cc066dc33ed69a9b/javascript/ql/src/Security/CWE-078/examples/shell-command-injection-from-environment.js#L4-L4)
|
1. [javascript/ql/src/Security/CWE-078/examples/shell-command-injection-from-environment.js](https://github.com/github/codeql/blob/48015e5a2e6202131f2d1062cc066dc33ed69a9b/javascript/ql/src/Security/CWE-078/examples/shell-command-injection-from-environment.js#L4-L4)
|
||||||
<pre><code class="javascript"> path = require("path");
|
<pre><code class="javascript"> path = require("path");
|
||||||
function cleanupTemp() {
|
function cleanupTemp() {
|
||||||
@@ -69,10 +70,11 @@
|
|||||||
|
|
||||||
*This shell command depends on an uncontrolled [absolute path](https://github.com/github/codeql/blob/48015e5a2e6202131f2d1062cc066dc33ed69a9b/javascript/ql/test/query-tests/Security/CWE-078/tst_shell-command-injection-from-environment.js#L6-L6).*
|
*This shell command depends on an uncontrolled [absolute path](https://github.com/github/codeql/blob/48015e5a2e6202131f2d1062cc066dc33ed69a9b/javascript/ql/test/query-tests/Security/CWE-078/tst_shell-command-injection-from-environment.js#L6-L6).*
|
||||||
|
|
||||||
<details>
|
#### Paths
|
||||||
<summary>Show paths</summary>
|
|
||||||
|
<details>
|
||||||
|
<summary>Path with 3 steps</summary>
|
||||||
|
|
||||||
#### Path with 3 steps
|
|
||||||
1. [javascript/ql/test/query-tests/Security/CWE-078/tst_shell-command-injection-from-environment.js](https://github.com/github/codeql/blob/48015e5a2e6202131f2d1062cc066dc33ed69a9b/javascript/ql/test/query-tests/Security/CWE-078/tst_shell-command-injection-from-environment.js#L6-L6)
|
1. [javascript/ql/test/query-tests/Security/CWE-078/tst_shell-command-injection-from-environment.js](https://github.com/github/codeql/blob/48015e5a2e6202131f2d1062cc066dc33ed69a9b/javascript/ql/test/query-tests/Security/CWE-078/tst_shell-command-injection-from-environment.js#L6-L6)
|
||||||
<pre><code class="javascript">(function() {
|
<pre><code class="javascript">(function() {
|
||||||
cp.execFileSync('rm', ['-rf', path.join(__dirname, "temp")]); // GOOD
|
cp.execFileSync('rm', ['-rf', path.join(__dirname, "temp")]); // GOOD
|
||||||
@@ -113,10 +115,11 @@
|
|||||||
|
|
||||||
*This shell command depends on an uncontrolled [absolute path](https://github.com/github/codeql/blob/48015e5a2e6202131f2d1062cc066dc33ed69a9b/javascript/ql/test/query-tests/Security/CWE-078/tst_shell-command-injection-from-environment.js#L8-L8).*
|
*This shell command depends on an uncontrolled [absolute path](https://github.com/github/codeql/blob/48015e5a2e6202131f2d1062cc066dc33ed69a9b/javascript/ql/test/query-tests/Security/CWE-078/tst_shell-command-injection-from-environment.js#L8-L8).*
|
||||||
|
|
||||||
<details>
|
#### Paths
|
||||||
<summary>Show paths</summary>
|
|
||||||
|
<details>
|
||||||
|
<summary>Path with 3 steps</summary>
|
||||||
|
|
||||||
#### Path with 3 steps
|
|
||||||
1. [javascript/ql/test/query-tests/Security/CWE-078/tst_shell-command-injection-from-environment.js](https://github.com/github/codeql/blob/48015e5a2e6202131f2d1062cc066dc33ed69a9b/javascript/ql/test/query-tests/Security/CWE-078/tst_shell-command-injection-from-environment.js#L8-L8)
|
1. [javascript/ql/test/query-tests/Security/CWE-078/tst_shell-command-injection-from-environment.js](https://github.com/github/codeql/blob/48015e5a2e6202131f2d1062cc066dc33ed69a9b/javascript/ql/test/query-tests/Security/CWE-078/tst_shell-command-injection-from-environment.js#L8-L8)
|
||||||
<pre><code class="javascript"> cp.execSync('rm -rf ' + path.join(__dirname, "temp")); // BAD
|
<pre><code class="javascript"> cp.execSync('rm -rf ' + path.join(__dirname, "temp")); // BAD
|
||||||
|
|
||||||
@@ -157,10 +160,11 @@
|
|||||||
|
|
||||||
*This shell command depends on an uncontrolled [absolute path](https://github.com/github/codeql/blob/48015e5a2e6202131f2d1062cc066dc33ed69a9b/javascript/ql/test/query-tests/Security/CWE-078/tst_shell-command-injection-from-environment.js#L9-L9).*
|
*This shell command depends on an uncontrolled [absolute path](https://github.com/github/codeql/blob/48015e5a2e6202131f2d1062cc066dc33ed69a9b/javascript/ql/test/query-tests/Security/CWE-078/tst_shell-command-injection-from-environment.js#L9-L9).*
|
||||||
|
|
||||||
<details>
|
#### Paths
|
||||||
<summary>Show paths</summary>
|
|
||||||
|
<details>
|
||||||
|
<summary>Path with 3 steps</summary>
|
||||||
|
|
||||||
#### Path with 3 steps
|
|
||||||
1. [javascript/ql/test/query-tests/Security/CWE-078/tst_shell-command-injection-from-environment.js](https://github.com/github/codeql/blob/48015e5a2e6202131f2d1062cc066dc33ed69a9b/javascript/ql/test/query-tests/Security/CWE-078/tst_shell-command-injection-from-environment.js#L9-L9)
|
1. [javascript/ql/test/query-tests/Security/CWE-078/tst_shell-command-injection-from-environment.js](https://github.com/github/codeql/blob/48015e5a2e6202131f2d1062cc066dc33ed69a9b/javascript/ql/test/query-tests/Security/CWE-078/tst_shell-command-injection-from-environment.js#L9-L9)
|
||||||
<pre><code class="javascript">
|
<pre><code class="javascript">
|
||||||
execa.shell('rm -rf ' + path.join(__dirname, "temp")); // NOT OK
|
execa.shell('rm -rf ' + path.join(__dirname, "temp")); // NOT OK
|
||||||
|
|||||||
@@ -11,10 +11,11 @@
|
|||||||
|
|
||||||
*This shell command depends on an uncontrolled [absolute path](https://github.com/meteor/meteor/blob/73b538fe201cbfe89dd0c709689023f9b3eab1ec/npm-packages/meteor-installer/config.js#L39-L39).*
|
*This shell command depends on an uncontrolled [absolute path](https://github.com/meteor/meteor/blob/73b538fe201cbfe89dd0c709689023f9b3eab1ec/npm-packages/meteor-installer/config.js#L39-L39).*
|
||||||
|
|
||||||
<details>
|
#### Paths
|
||||||
<summary>Show paths</summary>
|
|
||||||
|
<details>
|
||||||
|
<summary>Path with 7 steps</summary>
|
||||||
|
|
||||||
#### Path with 7 steps
|
|
||||||
1. [npm-packages/meteor-installer/config.js](https://github.com/meteor/meteor/blob/73b538fe201cbfe89dd0c709689023f9b3eab1ec/npm-packages/meteor-installer/config.js#L39-L39)
|
1. [npm-packages/meteor-installer/config.js](https://github.com/meteor/meteor/blob/73b538fe201cbfe89dd0c709689023f9b3eab1ec/npm-packages/meteor-installer/config.js#L39-L39)
|
||||||
<pre><code class="javascript">
|
<pre><code class="javascript">
|
||||||
const meteorLocalFolder = '.meteor';
|
const meteorLocalFolder = '.meteor';
|
||||||
@@ -83,7 +84,12 @@
|
|||||||
}
|
}
|
||||||
</code></pre>
|
</code></pre>
|
||||||
|
|
||||||
#### Path with 2 steps
|
|
||||||
|
</details>
|
||||||
|
|
||||||
|
<details>
|
||||||
|
<summary>Path with 2 steps</summary>
|
||||||
|
|
||||||
1. [npm-packages/meteor-installer/config.js](https://github.com/meteor/meteor/blob/73b538fe201cbfe89dd0c709689023f9b3eab1ec/npm-packages/meteor-installer/config.js#L39-L39)
|
1. [npm-packages/meteor-installer/config.js](https://github.com/meteor/meteor/blob/73b538fe201cbfe89dd0c709689023f9b3eab1ec/npm-packages/meteor-installer/config.js#L39-L39)
|
||||||
<pre><code class="javascript">
|
<pre><code class="javascript">
|
||||||
const meteorLocalFolder = '.meteor';
|
const meteorLocalFolder = '.meteor';
|
||||||
|
|||||||
Reference in New Issue
Block a user