diff --git a/extensions/ql-vscode/package.json b/extensions/ql-vscode/package.json index 4080fedd5..ec5a0673a 100644 --- a/extensions/ql-vscode/package.json +++ b/extensions/ql-vscode/package.json @@ -314,10 +314,6 @@ "command": "codeQL.exportVariantAnalysisResults", "title": "CodeQL: Export Variant Analysis Results" }, - { - "command": "codeQL.mockVariantAnalysisView", - "title": "CodeQL: Open Variant Analysis Mock View" - }, { "command": "codeQL.runQueries", "title": "CodeQL: Run Queries in Selected Files" @@ -898,10 +894,6 @@ "command": "codeQL.exportVariantAnalysisResults", "when": "config.codeQL.canary" }, - { - "command": "codeQL.mockVariantAnalysisView", - "when": "config.codeQL.canary && config.codeQL.variantAnalysis.liveResults" - }, { "command": "codeQL.runQueries", "when": "false" diff --git a/extensions/ql-vscode/src/extension.ts b/extensions/ql-vscode/src/extension.ts index 2e08d8cf2..c73d2bb9c 100644 --- a/extensions/ql-vscode/src/extension.ts +++ b/extensions/ql-vscode/src/extension.ts @@ -960,15 +960,6 @@ async function activateWithInstalledDistribution( }) ); - ctx.subscriptions.push( - commandRunner('codeQL.mockVariantAnalysisView', async () => { - // Generate a random variant analysis ID for testing - const variantAnalysisId: number = Math.floor(Math.random() * 1000000); - - await variantAnalysisManager.showView(variantAnalysisId); - }) - ); - ctx.subscriptions.push( commandRunner('codeQL.loadVariantAnalysisRepoResults', async (variantAnalysisId: number, repositoryFullName: string) => { await variantAnalysisManager.loadResults(variantAnalysisId, repositoryFullName); diff --git a/extensions/ql-vscode/src/remote-queries/variant-analysis-manager.ts b/extensions/ql-vscode/src/remote-queries/variant-analysis-manager.ts index 97c96877f..f6620756b 100644 --- a/extensions/ql-vscode/src/remote-queries/variant-analysis-manager.ts +++ b/extensions/ql-vscode/src/remote-queries/variant-analysis-manager.ts @@ -71,6 +71,10 @@ export class VariantAnalysisManager extends DisposableObject implements VariantA return this.views.get(variantAnalysisId); } + public async getVariantAnalysis(variantAnalysisId: number): Promise { + return this.variantAnalyses.get(variantAnalysisId); + } + public async loadResults(variantAnalysisId: number, repositoryFullName: string): Promise { const variantAnalysis = this.variantAnalyses.get(variantAnalysisId); if (!variantAnalysis) { diff --git a/extensions/ql-vscode/src/remote-queries/variant-analysis-view-manager.ts b/extensions/ql-vscode/src/remote-queries/variant-analysis-view-manager.ts index fcfbf838b..3356fa61b 100644 --- a/extensions/ql-vscode/src/remote-queries/variant-analysis-view-manager.ts +++ b/extensions/ql-vscode/src/remote-queries/variant-analysis-view-manager.ts @@ -1,3 +1,5 @@ +import { VariantAnalysis } from './shared/variant-analysis'; + export interface VariantAnalysisViewInterface { variantAnalysisId: number; openView(): Promise; @@ -6,4 +8,6 @@ export interface VariantAnalysisViewInterface { export interface VariantAnalysisViewManager { registerView(view: T): void; unregisterView(view: T): void; + + getVariantAnalysis(variantAnalysisId: number): Promise; } diff --git a/extensions/ql-vscode/src/remote-queries/variant-analysis-view.ts b/extensions/ql-vscode/src/remote-queries/variant-analysis-view.ts index 91c691b5a..28d707783 100644 --- a/extensions/ql-vscode/src/remote-queries/variant-analysis-view.ts +++ b/extensions/ql-vscode/src/remote-queries/variant-analysis-view.ts @@ -5,13 +5,11 @@ import { FromVariantAnalysisMessage, ToVariantAnalysisMessage } from '../pure/in import { assertNever } from '../pure/helpers-pure'; import { VariantAnalysis, - VariantAnalysisQueryLanguage, - VariantAnalysisRepoStatus, VariantAnalysisScannedRepositoryResult, VariantAnalysisScannedRepositoryState, - VariantAnalysisStatus } from './shared/variant-analysis'; import { VariantAnalysisViewInterface, VariantAnalysisViewManager } from './variant-analysis-view-manager'; +import { showAndLogWarningMessage } from '../helpers'; export class VariantAnalysisView extends AbstractWebview implements VariantAnalysisViewInterface { public static readonly viewType = 'codeQL.variantAnalysis'; @@ -82,14 +80,7 @@ export class VariantAnalysisView extends AbstractWebview { switch (msg.t) { case 'viewLoaded': - this.onWebViewLoaded(); - - void logger.log('Variant analysis view loaded'); - - await this.postMessage({ - t: 'setVariantAnalysis', - variantAnalysis: this.getVariantAnalysis(), - }); + await this.onWebViewLoaded(); break; case 'stopVariantAnalysis': @@ -103,152 +94,21 @@ export class VariantAnalysisView extends AbstractWebview(); + const [variantAnalysis, setVariantAnalysis] = useState(initialVariantAnalysis); const [repoStates, setRepoStates] = useState(initialRepoStates); const [repoResults, setRepoResults] = useState(initialRepoResults);