mrva/vscode-codeql
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Move "total" row to the top and render the metric

Browse Source
This commit is contained in:
Asger F
2024-11-27 10:20:21 +01:00
parent d37469fc94
commit 8a58279e67
1 changed files with 14 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
extensions/ql-vscode/src/view/compare-performance/ComparePerformance.tsx
View File

@@ -611,6 +611,20 @@ function ComparePerformanceWithData(props: {
<NameHeader>Predicate</NameHeader>
</HeaderTR>
</thead>
<tbody>
<tr key="total">
<ChevronCell />
{comparison && renderOptionalValue(totalBefore, metric.unit)}
{renderOptionalValue(totalAfter, metric.unit)}
{comparison && renderDelta(totalDiff, metric.unit)}
<NameCell>
<strong>TOTAL</strong>
</NameCell>
</tr>
<tr key="spacing">
<td colSpan={5} style={{ height: "1em" }}></td>
</tr>
</tbody>
</Table>
<PredicateTable
rowGroups={rowGroups}
@@ -619,22 +633,6 @@ function ComparePerformanceWithData(props: {
metric={metric}
isPerEvaluation={isPerEvaluation}
/>
<Table>
<tfoot>
<tr key="spacing">
<td colSpan={5} style={{ height: "1em" }}></td>
</tr>
<tr key="total">
<ChevronCell />
{comparison && (
<NumberCell>{formatDecimal(totalBefore)}</NumberCell>
)}
<NumberCell>{formatDecimal(totalAfter)}</NumberCell>
{comparison && renderDelta(totalDiff)}
<NameCell>TOTAL</NameCell>
</tr>
</tfoot>
</Table>
</>
);
}