mrva/vscode-codeql
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Include full usage in jumpToUsage message

Browse Source
This commit is contained in:
Robert
2023-08-08 15:57:30 +01:00
parent 209822e093
commit 805bb74a8a
3 changed files with 9 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
extensions/ql-vscode/src/common/interface-types.ts
View File

@@ -17,7 +17,10 @@ import {
} from "../variant-analysis/shared/variant-analysis-filter-sort"; } from "../variant-analysis/shared/variant-analysis-filter-sort";
import { ErrorLike } from "../common/errors"; import { ErrorLike } from "../common/errors";
import { DataFlowPaths } from "../variant-analysis/shared/data-flow-paths"; import { DataFlowPaths } from "../variant-analysis/shared/data-flow-paths";
import { ExternalApiUsage } from "../data-extensions-editor/external-api-usage"; import {
ExternalApiUsage,
Usage,
} from "../data-extensions-editor/external-api-usage";
import { ModeledMethod } from "../data-extensions-editor/modeled-method"; import { ModeledMethod } from "../data-extensions-editor/modeled-method";
import { DataExtensionEditorViewState } from "../data-extensions-editor/shared/view-state"; import { DataExtensionEditorViewState } from "../data-extensions-editor/shared/view-state";
import { Mode } from "../data-extensions-editor/shared/mode"; import { Mode } from "../data-extensions-editor/shared/mode";
@@ -522,7 +525,7 @@ interface SwitchModeMessage {
interface JumpToUsageMessage { interface JumpToUsageMessage {
t: "jumpToUsage"; t: "jumpToUsage";
location: ResolvableLocationValue; usage: Usage;
} }
interface OpenDatabaseMessage { interface OpenDatabaseMessage {

6
extensions/ql-vscode/src/data-extensions-editor/data-extensions-editor-view.ts
View File

@@ -153,7 +153,7 @@ export class DataExtensionsEditorView extends AbstractWebview<
break; break;
case "jumpToUsage": case "jumpToUsage":
await this.handleJumpToUsage(msg.location); await this.handleJumpToUsage(msg.usage);
break; break;
case "saveModeledMethods": case "saveModeledMethods":
@@ -230,11 +230,11 @@ export class DataExtensionsEditorView extends AbstractWebview<
}); });
} }
protected async handleJumpToUsage(location: ResolvableLocationValue) { protected async handleJumpToUsage(usage: Usage) {
if (showModelDetailsView()) { if (showModelDetailsView()) {
await this.openModelDetailsView(); await this.openModelDetailsView();
} else { } else {
await this.jumpToUsage(location); await this.jumpToUsage(usage.url);
} }
} }

2
extensions/ql-vscode/src/view/data-extensions-editor/MethodRow.tsx
View File

@@ -326,7 +326,7 @@ function sendJumpToUsageMessage(externalApiUsage: ExternalApiUsage) {
vscode.postMessage({ vscode.postMessage({
t: "jumpToUsage", t: "jumpToUsage",
// In framework mode, the first and only usage is the definition of the method // In framework mode, the first and only usage is the definition of the method
location: externalApiUsage.usages[0].url, usage: externalApiUsage.usages[0],
}); });
} }