From 7a5e654a80b3ee92e524c02646d3ab5f48b08ad5 Mon Sep 17 00:00:00 2001 From: Sam Partington Date: Wed, 5 Apr 2023 14:35:07 +0100 Subject: [PATCH] Add comment about base config https://github.com/github/vscode-codeql/pull/2268#discussion_r1158488461 --- .vscode/settings.json | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/.vscode/settings.json b/.vscode/settings.json index 6dee0f120..f61c6b3dc 100644 --- a/.vscode/settings.json +++ b/.vscode/settings.json @@ -52,8 +52,13 @@ "./extensions/ql-vscode/node_modules/@github/markdownlint-github/src/rules/no-generic-link-text.js" ], - // This ensures that the rule enablement done by github-markdownlint is considered - // by the extension too. + // This ensures that the accessibility rule enablement done by github-markdownlint is + // considered by the extension too. + // + // Unfortunately, we can only specify a single extends, so the config here isn't + // identical since it can't also consider @github/markdownlint-github/style/base.json + // That's not as bad as it could be since the full config is considered for anything + // in extensions/ql-vscode/ or its subfolders anyway. // // Additional nonfiguration of the default rules is done in .markdownlint.json, // which is picked up by the extension automatically, and read explicitly in