mrva/vscode-codeql
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Merge pull request #3859 from github/koesie10/upgrade-e2e-versions

Browse Source 
Upgrade code-server version for E2E tests
This commit is contained in:
Koen Vlaswinkel
2024-12-11 10:10:32 +01:00
committed by GitHub
parent a6da43b9e9 54e531d175
commit 7610de24c8
3 changed files with 5 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
extensions/ql-vscode/test/e2e/README.md
View File

@@ -9,12 +9,12 @@ Setup
- install playwright if you haven't yet (`npx playwright install`) - install playwright if you haven't yet (`npx playwright install`)
- go to the e2e test folder on your terminal - go to the e2e test folder on your terminal
- make sure docker is running - make sure docker is running
- run `docker-compose build` - run `docker compose build`
- run `docker-compose up` - run `docker compose up`
Run tests Run tests
- run `npx playwright test --ui` from the e2e test folder to follow the test while it's running. This UI has a 'locator' tool with which elements on the test screen can be found - run `npx playwright test --ui` from the e2e test folder to follow the test while it's running. This UI has a 'locator' tool with which elements on the test screen can be found
- use `npx playwright test --debug` to follow the test in real time and interact with the interface, e.g. press enter or input into fields, stop and start - use `npx playwright test --debug` to follow the test in real time and interact with the interface, e.g. press enter or input into fields, stop and start
During the test elements are created in the docker volume, e.g. the downloaded database or query data. This might interfer with other tests or when running a test twice. If that happens restart your docker volume by using `docker-compose down -v` and `docker-compose up`. Sometimes already existing queries from former runs change the input the extension needs. During the test elements are created in the docker volume, e.g. the downloaded database or query data. This might interfer with other tests or when running a test twice. If that happens restart your docker volume by using `docker-compose down -v` and `docker-compose up`. Sometimes already existing queries from former runs change the input the extension needs.

4
extensions/ql-vscode/test/e2e/docker-compose.yml
View File

@@ -1,5 +1,3 @@
version: "3.8"
services: services:
code-server: code-server:
build: build:
@@ -38,7 +36,7 @@ services:
depends_on: depends_on:
- files-init - files-init
files-init: files-init:
image: alpine:3.19.1 image: alpine:3.21.0
restart: "no" restart: "no"
# Since we're not running the code-server container using the same user as our host user, # Since we're not running the code-server container using the same user as our host user,
# we need to set the permissions on the mounted volumes to match the user inside the container. # we need to set the permissions on the mounted volumes to match the user inside the container.

2
extensions/ql-vscode/test/e2e/docker/Dockerfile
View File

@@ -1,4 +1,4 @@
FROM codercom/code-server:4.23.1 FROM codercom/code-server:4.95.3
USER root USER root