diff --git a/extensions/ql-vscode/package.json b/extensions/ql-vscode/package.json index 3030bbcda..57e3065b1 100644 --- a/extensions/ql-vscode/package.json +++ b/extensions/ql-vscode/package.json @@ -1281,8 +1281,7 @@ }, { "id": "codeQLVariantAnalysisRepositories", - "name": "Variant Analysis Repositories", - "when": "config.codeQL.canary" + "name": "Variant Analysis Repositories" }, { "id": "codeQLQueryHistory", diff --git a/extensions/ql-vscode/src/databases/db-module.ts b/extensions/ql-vscode/src/databases/db-module.ts index f81b42d25..ceb46779a 100644 --- a/extensions/ql-vscode/src/databases/db-module.ts +++ b/extensions/ql-vscode/src/databases/db-module.ts @@ -1,12 +1,11 @@ import { window } from "vscode"; -import { App, AppMode } from "../common/app"; +import { App } from "../common/app"; import { extLogger } from "../common"; import { DisposableObject } from "../pure/disposable-object"; import { DbConfigStore } from "./config/db-config-store"; import { DbManager } from "./db-manager"; import { DbPanel } from "./ui/db-panel"; import { DbSelectionDecorationProvider } from "./ui/db-selection-decoration-provider"; -import { isCanary } from "../config"; export class DbModule extends DisposableObject { public readonly dbManager: DbManager; @@ -19,24 +18,12 @@ export class DbModule extends DisposableObject { this.dbManager = new DbManager(app, this.dbConfigStore); } - public static async initialize(app: App): Promise { - if (DbModule.shouldEnableModule(app.mode)) { - const dbModule = new DbModule(app); - app.subscriptions.push(dbModule); + public static async initialize(app: App): Promise { + const dbModule = new DbModule(app); + app.subscriptions.push(dbModule); - await dbModule.initialize(app); - return dbModule; - } - - return undefined; - } - - private static shouldEnableModule(app: AppMode): boolean { - if (app === AppMode.Development || app === AppMode.Test) { - return true; - } - - return isCanary(); + await dbModule.initialize(app); + return dbModule; } private async initialize(app: App): Promise { diff --git a/extensions/ql-vscode/src/extension.ts b/extensions/ql-vscode/src/extension.ts index f01a926f1..4ec6b2858 100644 --- a/extensions/ql-vscode/src/extension.ts +++ b/extensions/ql-vscode/src/extension.ts @@ -644,7 +644,7 @@ async function activateWithInstalledDistribution( cliServer, variantAnalysisStorageDir, variantAnalysisResultsManager, - dbModule?.dbManager, + dbModule.dbManager, ); ctx.subscriptions.push(variantAnalysisManager); ctx.subscriptions.push(variantAnalysisResultsManager); diff --git a/extensions/ql-vscode/src/variant-analysis/repository-selection.ts b/extensions/ql-vscode/src/variant-analysis/repository-selection.ts index c289067de..59f0b7b7b 100644 --- a/extensions/ql-vscode/src/variant-analysis/repository-selection.ts +++ b/extensions/ql-vscode/src/variant-analysis/repository-selection.ts @@ -13,9 +13,9 @@ export interface RepositorySelection { * @returns The user selection. */ export async function getRepositorySelection( - dbManager?: DbManager, + dbManager: DbManager, ): Promise { - const selectedDbItem = dbManager?.getSelectedDbItem(); + const selectedDbItem = dbManager.getSelectedDbItem(); if (selectedDbItem) { switch (selectedDbItem.kind) { case DbItemKind.LocalDatabase || DbItemKind.LocalList: diff --git a/extensions/ql-vscode/src/variant-analysis/run-remote-query.ts b/extensions/ql-vscode/src/variant-analysis/run-remote-query.ts index ffeb1d89a..8b64aa8c7 100644 --- a/extensions/ql-vscode/src/variant-analysis/run-remote-query.ts +++ b/extensions/ql-vscode/src/variant-analysis/run-remote-query.ts @@ -223,7 +223,7 @@ export async function prepareRemoteQueryRun( uri: Uri | undefined, progress: ProgressCallback, token: CancellationToken, - dbManager?: DbManager, + dbManager: DbManager, ): Promise { if (!uri?.fsPath.endsWith(".ql")) { throw new UserCancellationException("Not a CodeQL query file."); diff --git a/extensions/ql-vscode/src/variant-analysis/variant-analysis-manager.ts b/extensions/ql-vscode/src/variant-analysis/variant-analysis-manager.ts index 9156617f4..af42da85c 100644 --- a/extensions/ql-vscode/src/variant-analysis/variant-analysis-manager.ts +++ b/extensions/ql-vscode/src/variant-analysis/variant-analysis-manager.ts @@ -105,7 +105,7 @@ export class VariantAnalysisManager private readonly cliServer: CodeQLCliServer, private readonly storagePath: string, private readonly variantAnalysisResultsManager: VariantAnalysisResultsManager, - private readonly dbManager?: DbManager, + private readonly dbManager: DbManager, ) { super(); this.variantAnalysisMonitor = this.push(