Implement "Hide modeled APIs" checkbox and make it the default (#2651)

This commit is contained in:
Shati Patel
2023-07-27 16:49:41 +01:00
committed by GitHub
parent ca16dca7ed
commit 6e21706c15
5 changed files with 27 additions and 2 deletions

View File

@@ -91,6 +91,8 @@ export function DataExtensionsEditor({
new Set(), new Set(),
); );
const [hideModeledApis, setHideModeledApis] = useState(true);
const [modeledMethods, setModeledMethods] = useState< const [modeledMethods, setModeledMethods] = useState<
Record<string, ModeledMethod> Record<string, ModeledMethod>
>(initialModeledMethods); >(initialModeledMethods);
@@ -252,6 +254,10 @@ export function DataExtensionsEditor({
}); });
}, [viewState?.mode]); }, [viewState?.mode]);
const onHideModeledApis = useCallback(() => {
setHideModeledApis((oldHideModeledApis) => !oldHideModeledApis);
}, []);
if (viewState === undefined || externalApiUsages.length === 0) { if (viewState === undefined || externalApiUsages.length === 0) {
return <LoadingContainer>Loading...</LoadingContainer>; return <LoadingContainer>Loading...</LoadingContainer>;
} }
@@ -292,7 +298,12 @@ export function DataExtensionsEditor({
</HeaderColumn> </HeaderColumn>
<HeaderSpacer /> <HeaderSpacer />
<HeaderColumn> <HeaderColumn>
<VSCodeCheckbox>Hide modeled APIs</VSCodeCheckbox> <VSCodeCheckbox
checked={hideModeledApis}
onChange={onHideModeledApis}
>
Hide modeled APIs
</VSCodeCheckbox>
</HeaderColumn> </HeaderColumn>
</HeaderContainer> </HeaderContainer>
@@ -320,6 +331,7 @@ export function DataExtensionsEditor({
modeledMethods={modeledMethods} modeledMethods={modeledMethods}
modifiedSignatures={modifiedSignatures} modifiedSignatures={modifiedSignatures}
viewState={viewState} viewState={viewState}
hideModeledApis={hideModeledApis}
onChange={onChange} onChange={onChange}
onSaveModelClick={onSaveModelClick} onSaveModelClick={onSaveModelClick}
onGenerateFromLlmClick={onGenerateFromLlmClick} onGenerateFromLlmClick={onGenerateFromLlmClick}

View File

@@ -73,6 +73,7 @@ type Props = {
modeledMethods: Record<string, ModeledMethod>; modeledMethods: Record<string, ModeledMethod>;
modifiedSignatures: Set<string>; modifiedSignatures: Set<string>;
viewState: DataExtensionEditorViewState; viewState: DataExtensionEditorViewState;
hideModeledApis: boolean;
onChange: ( onChange: (
modelName: string, modelName: string,
externalApiUsage: ExternalApiUsage, externalApiUsage: ExternalApiUsage,
@@ -97,6 +98,7 @@ export const LibraryRow = ({
modeledMethods, modeledMethods,
modifiedSignatures, modifiedSignatures,
viewState, viewState,
hideModeledApis,
onChange, onChange,
onSaveModelClick, onSaveModelClick,
onGenerateFromLlmClick, onGenerateFromLlmClick,
@@ -208,6 +210,7 @@ export const LibraryRow = ({
modeledMethods={modeledMethods} modeledMethods={modeledMethods}
modifiedSignatures={modifiedSignatures} modifiedSignatures={modifiedSignatures}
mode={viewState.mode} mode={viewState.mode}
hideModeledApis={hideModeledApis}
onChange={onChangeWithModelName} onChange={onChangeWithModelName}
/> />
<SectionDivider /> <SectionDivider />

View File

@@ -56,6 +56,7 @@ type Props = {
modeledMethod: ModeledMethod | undefined; modeledMethod: ModeledMethod | undefined;
methodIsUnsaved: boolean; methodIsUnsaved: boolean;
mode: Mode; mode: Mode;
hideModeledApis: boolean;
onChange: ( onChange: (
externalApiUsage: ExternalApiUsage, externalApiUsage: ExternalApiUsage,
modeledMethod: ModeledMethod, modeledMethod: ModeledMethod,
@@ -63,7 +64,8 @@ type Props = {
}; };
export const MethodRow = (props: Props) => { export const MethodRow = (props: Props) => {
const { externalApiUsage, modeledMethod, methodIsUnsaved } = props; const { externalApiUsage, modeledMethod, methodIsUnsaved, hideModeledApis } =
props;
const methodCanBeModeled = const methodCanBeModeled =
!externalApiUsage.supported || !externalApiUsage.supported ||
@@ -72,6 +74,8 @@ export const MethodRow = (props: Props) => {
if (methodCanBeModeled) { if (methodCanBeModeled) {
return <ModelableMethodRow {...props} />; return <ModelableMethodRow {...props} />;
} else if (hideModeledApis) {
return null;
} else { } else {
return <UnmodelableMethodRow {...props} />; return <UnmodelableMethodRow {...props} />;
} }

View File

@@ -16,6 +16,7 @@ type Props = {
modeledMethods: Record<string, ModeledMethod>; modeledMethods: Record<string, ModeledMethod>;
modifiedSignatures: Set<string>; modifiedSignatures: Set<string>;
mode: Mode; mode: Mode;
hideModeledApis: boolean;
onChange: ( onChange: (
externalApiUsage: ExternalApiUsage, externalApiUsage: ExternalApiUsage,
modeledMethod: ModeledMethod, modeledMethod: ModeledMethod,
@@ -27,6 +28,7 @@ export const ModeledMethodDataGrid = ({
modeledMethods, modeledMethods,
modifiedSignatures, modifiedSignatures,
mode, mode,
hideModeledApis,
onChange, onChange,
}: Props) => { }: Props) => {
const sortedExternalApiUsages = useMemo( const sortedExternalApiUsages = useMemo(
@@ -60,6 +62,7 @@ export const ModeledMethodDataGrid = ({
modeledMethod={modeledMethods[externalApiUsage.signature]} modeledMethod={modeledMethods[externalApiUsage.signature]}
methodIsUnsaved={modifiedSignatures.has(externalApiUsage.signature)} methodIsUnsaved={modifiedSignatures.has(externalApiUsage.signature)}
mode={mode} mode={mode}
hideModeledApis={hideModeledApis}
onChange={onChange} onChange={onChange}
/> />
))} ))}

View File

@@ -15,6 +15,7 @@ type Props = {
modeledMethods: Record<string, ModeledMethod>; modeledMethods: Record<string, ModeledMethod>;
modifiedSignatures: Set<string>; modifiedSignatures: Set<string>;
viewState: DataExtensionEditorViewState; viewState: DataExtensionEditorViewState;
hideModeledApis: boolean;
onChange: ( onChange: (
modelName: string, modelName: string,
externalApiUsage: ExternalApiUsage, externalApiUsage: ExternalApiUsage,
@@ -41,6 +42,7 @@ export const ModeledMethodsList = ({
modeledMethods, modeledMethods,
modifiedSignatures, modifiedSignatures,
viewState, viewState,
hideModeledApis,
onChange, onChange,
onSaveModelClick, onSaveModelClick,
onGenerateFromLlmClick, onGenerateFromLlmClick,
@@ -83,6 +85,7 @@ export const ModeledMethodsList = ({
modeledMethods={modeledMethods} modeledMethods={modeledMethods}
modifiedSignatures={modifiedSignatures} modifiedSignatures={modifiedSignatures}
viewState={viewState} viewState={viewState}
hideModeledApis={hideModeledApis}
onChange={onChange} onChange={onChange}
onSaveModelClick={onSaveModelClick} onSaveModelClick={onSaveModelClick}
onGenerateFromLlmClick={onGenerateFromLlmClick} onGenerateFromLlmClick={onGenerateFromLlmClick}