From 6aaa7d63a7580d6e54336782efc57da38173d5df Mon Sep 17 00:00:00 2001 From: Koen Vlaswinkel Date: Wed, 16 Nov 2022 13:02:55 +0100 Subject: [PATCH] Simplify type checks for `repositoryIds` --- .../ql-vscode/src/pure/variant-analysis-filter-sort.ts | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/extensions/ql-vscode/src/pure/variant-analysis-filter-sort.ts b/extensions/ql-vscode/src/pure/variant-analysis-filter-sort.ts index 733cf7dc1..6a8c4e7ed 100644 --- a/extensions/ql-vscode/src/pure/variant-analysis-filter-sort.ts +++ b/extensions/ql-vscode/src/pure/variant-analysis-filter-sort.ts @@ -76,16 +76,8 @@ export function compareWithResults(filterSortState: RepositoriesFilterSortState }; } -function hasRepositoryIds(filterSortState: RepositoriesFilterSortState | RepositoriesFilterSortStateWithIds | undefined): filterSortState is RepositoriesFilterSortStateWithIds { - if (!filterSortState) { - return false; - } - - return 'repositoryIds' in filterSortState; -} - function isFilterOnRepositoryIds(filterSortState: RepositoriesFilterSortState | RepositoriesFilterSortStateWithIds | undefined): filterSortState is RepositoriesFilterSortStateWithIds & Required> { - return hasRepositoryIds(filterSortState) && filterSortState.repositoryIds !== undefined && filterSortState.repositoryIds.length > 0; + return !!filterSortState && 'repositoryIds' in filterSortState && filterSortState.repositoryIds !== undefined && filterSortState.repositoryIds.length > 0; } // These define the behavior for undefined input values