mrva/vscode-codeql
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Rename some variables

Browse Source
This commit is contained in:
Koen Vlaswinkel
2022-10-21 10:43:32 +02:00
parent 463633334c
commit 66c6bf5e86
2 changed files with 14 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
extensions/ql-vscode/src/mocks/mock-gh-api-server.ts
View File

@@ -62,8 +62,8 @@ export class MockGitHubApiServer extends DisposableObject {
}
public async saveScenario(): Promise<void> {
const scenariosDirectory = await this.getScenariosDirectory();
if (!scenariosDirectory) {
const scenariosPath = await this.getScenariosPath();
if (!scenariosPath) {
return;
}
@@ -73,7 +73,7 @@ export class MockGitHubApiServer extends DisposableObject {
void window.showErrorMessage('No scenario is currently being recorded.');
return;
}
if (this.recorder.scenarioRequestCount === 0) {
if (!this.recorder.anyRequestsRecorded) {
void window.showWarningMessage('No requests were recorded. Cancelling scenario.');
await this.stopRecording();
@@ -90,13 +90,13 @@ export class MockGitHubApiServer extends DisposableObject {
return;
}
const filepath = await this.recorder.save(scenariosDirectory, name);
const filePath = await this.recorder.save(scenariosPath, name);
await this.stopRecording();
const action = await window.showInformationMessage(`Scenario saved to ${filepath}`, 'Open directory');
const action = await window.showInformationMessage(`Scenario saved to ${filePath}`, 'Open directory');
if (action === 'Open directory') {
await env.openExternal(Uri.file(filepath));
await env.openExternal(Uri.file(filePath));
}
}
@@ -118,10 +118,10 @@ export class MockGitHubApiServer extends DisposableObject {
await this.recorder.clear();
}
private async getScenariosDirectory(): Promise<string | undefined> {
const scenariosDirectory = getMockGitHubApiServerScenariosPath();
if (scenariosDirectory) {
return scenariosDirectory;
private async getScenariosPath(): Promise<string | undefined> {
const scenariosPath = getMockGitHubApiServerScenariosPath();
if (scenariosPath) {
return scenariosPath;
}
const directories = await window.showOpenDialog({

8
extensions/ql-vscode/src/mocks/recorder.ts
View File

@@ -27,8 +27,8 @@ export class Recorder extends DisposableObject {
return this._recording;
}
public get scenarioRequestCount(): number {
return this.currentRecordedScenario.length;
public get anyRequestsRecorded(): boolean {
return this.currentRecordedScenario.length > 0;
}
public start(): void {
@@ -60,8 +60,8 @@ export class Recorder extends DisposableObject {
this.allRequests.clear();
}
public async save(scenariosDirectory: string, name: string): Promise<string> {
const scenarioDirectory = path.join(scenariosDirectory, name);
public async save(scenariosPath: string, name: string): Promise<string> {
const scenarioDirectory = path.join(scenariosPath, name);
await fs.ensureDir(scenarioDirectory);