diff --git a/extensions/ql-vscode/src/stories/remote-queries/CodePaths.stories.tsx b/extensions/ql-vscode/src/stories/common/CodePaths.stories.tsx similarity index 95% rename from extensions/ql-vscode/src/stories/remote-queries/CodePaths.stories.tsx rename to extensions/ql-vscode/src/stories/common/CodePaths.stories.tsx index e3c4fc817..e20850f90 100644 --- a/extensions/ql-vscode/src/stories/remote-queries/CodePaths.stories.tsx +++ b/extensions/ql-vscode/src/stories/common/CodePaths.stories.tsx @@ -3,7 +3,7 @@ import React from 'react'; import { ComponentStory, ComponentMeta } from '@storybook/react'; import { ThemeProvider } from '@primer/react'; -import CodePaths from '../../view/remote-queries/CodePaths'; +import { CodePaths } from '../../view/common'; import type { CodeFlow } from '../../remote-queries/shared/analysis-result'; export default { @@ -112,8 +112,8 @@ PowerShell.args = { message: { tokens: [ { - type: 'text', - t: 'This zip file may have a dangerous path' + t: 'text', + text: 'This zip file may have a dangerous path' } ] }, diff --git a/extensions/ql-vscode/src/stories/remote-queries/FileCodeSnippet.stories.tsx b/extensions/ql-vscode/src/stories/common/FileCodeSnippet.stories.tsx similarity index 93% rename from extensions/ql-vscode/src/stories/remote-queries/FileCodeSnippet.stories.tsx rename to extensions/ql-vscode/src/stories/common/FileCodeSnippet.stories.tsx index e38c610ab..762352803 100644 --- a/extensions/ql-vscode/src/stories/remote-queries/FileCodeSnippet.stories.tsx +++ b/extensions/ql-vscode/src/stories/common/FileCodeSnippet.stories.tsx @@ -2,7 +2,7 @@ import React from 'react'; import { ComponentStory, ComponentMeta } from '@storybook/react'; -import FileCodeSnippet from '../../view/remote-queries/FileCodeSnippet'; +import { FileCodeSnippet } from '../../view/common'; export default { title: 'File Code Snippet', diff --git a/extensions/ql-vscode/src/view/remote-queries/CodePaths.tsx b/extensions/ql-vscode/src/view/common/CodePaths/CodePaths.tsx similarity index 95% rename from extensions/ql-vscode/src/view/remote-queries/CodePaths.tsx rename to extensions/ql-vscode/src/view/common/CodePaths/CodePaths.tsx index 64c4271ee..10872742a 100644 --- a/extensions/ql-vscode/src/view/remote-queries/CodePaths.tsx +++ b/extensions/ql-vscode/src/view/common/CodePaths/CodePaths.tsx @@ -4,9 +4,10 @@ import { VSCodeDropdown, VSCodeLink, VSCodeOption, VSCodeTag } from '@vscode/web import * as React from 'react'; import { ChangeEvent, useRef, useState } from 'react'; import styled from 'styled-components'; -import { CodeFlow, AnalysisMessage, ResultSeverity } from '../../remote-queries/shared/analysis-result'; -import { SectionTitle, VerticalSpace } from '../common'; -import FileCodeSnippet from './FileCodeSnippet'; +import { CodeFlow, AnalysisMessage, ResultSeverity } from '../../../remote-queries/shared/analysis-result'; +import { SectionTitle } from '../SectionTitle'; +import { VerticalSpace } from '../VerticalSpace'; +import { FileCodeSnippet } from '../FileCodeSnippet'; const StyledCloseButton = styled.button` position: absolute; @@ -111,7 +112,7 @@ const Menu = ({ ; }; -const CodePaths = ({ +export const CodePaths = ({ codeFlows, ruleDescription, message, @@ -173,5 +174,3 @@ const CodePaths = ({ ); }; - -export default CodePaths; diff --git a/extensions/ql-vscode/src/view/common/CodePaths/index.ts b/extensions/ql-vscode/src/view/common/CodePaths/index.ts new file mode 100644 index 000000000..3865ed37a --- /dev/null +++ b/extensions/ql-vscode/src/view/common/CodePaths/index.ts @@ -0,0 +1 @@ +export * from './CodePaths'; diff --git a/extensions/ql-vscode/src/view/remote-queries/FileCodeSnippet.tsx b/extensions/ql-vscode/src/view/common/FileCodeSnippet/FileCodeSnippet.tsx similarity index 96% rename from extensions/ql-vscode/src/view/remote-queries/FileCodeSnippet.tsx rename to extensions/ql-vscode/src/view/common/FileCodeSnippet/FileCodeSnippet.tsx index 955f6d91a..aea626b11 100644 --- a/extensions/ql-vscode/src/view/remote-queries/FileCodeSnippet.tsx +++ b/extensions/ql-vscode/src/view/common/FileCodeSnippet/FileCodeSnippet.tsx @@ -1,10 +1,10 @@ import * as React from 'react'; import styled from 'styled-components'; -import { CodeSnippet, FileLink, HighlightedRegion, AnalysisMessage, ResultSeverity } from '../../remote-queries/shared/analysis-result'; -import { createRemoteFileRef } from '../../pure/location-link-utils'; -import { parseHighlightedLine, shouldHighlightLine } from '../../pure/sarif-utils'; +import { CodeSnippet, FileLink, HighlightedRegion, AnalysisMessage, ResultSeverity } from '../../../remote-queries/shared/analysis-result'; +import { createRemoteFileRef } from '../../../pure/location-link-utils'; +import { parseHighlightedLine, shouldHighlightLine } from '../../../pure/sarif-utils'; import { VSCodeLink } from '@vscode/webview-ui-toolkit/react'; -import { VerticalSpace } from '../common'; +import { VerticalSpace } from '../VerticalSpace'; const borderColor = 'var(--vscode-editor-snippetFinalTabstopHighlightBorder)'; const warningColor = '#966C23'; @@ -193,7 +193,7 @@ const Line = ({ ; }; -const FileCodeSnippet = ({ +export const FileCodeSnippet = ({ fileLink, codeSnippet, highlightedRegion, @@ -257,5 +257,3 @@ const FileCodeSnippet = ({ ); }; - -export default FileCodeSnippet; diff --git a/extensions/ql-vscode/src/view/common/FileCodeSnippet/index.ts b/extensions/ql-vscode/src/view/common/FileCodeSnippet/index.ts new file mode 100644 index 000000000..9c8821669 --- /dev/null +++ b/extensions/ql-vscode/src/view/common/FileCodeSnippet/index.ts @@ -0,0 +1 @@ +export * from './FileCodeSnippet'; diff --git a/extensions/ql-vscode/src/view/common/index.ts b/extensions/ql-vscode/src/view/common/index.ts index 3e4a39db9..59429ee75 100644 --- a/extensions/ql-vscode/src/view/common/index.ts +++ b/extensions/ql-vscode/src/view/common/index.ts @@ -1,4 +1,6 @@ export * from './icon'; +export * from './CodePaths'; +export * from './FileCodeSnippet'; export * from './HorizontalSpace'; export * from './SectionTitle'; export * from './VerticalSpace'; diff --git a/extensions/ql-vscode/src/view/remote-queries/AnalysisAlertResult.tsx b/extensions/ql-vscode/src/view/remote-queries/AnalysisAlertResult.tsx index 94e57832b..2957b205f 100644 --- a/extensions/ql-vscode/src/view/remote-queries/AnalysisAlertResult.tsx +++ b/extensions/ql-vscode/src/view/remote-queries/AnalysisAlertResult.tsx @@ -1,7 +1,6 @@ import * as React from 'react'; import { AnalysisAlert } from '../../remote-queries/shared/analysis-result'; -import CodePaths from './CodePaths'; -import FileCodeSnippet from './FileCodeSnippet'; +import { CodePaths, FileCodeSnippet } from '../common'; const AnalysisAlertResult = ({ alert }: { alert: AnalysisAlert }) => { const showPathsLink = alert.codeFlows.length > 0;