mrva/vscode-codeql
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Fix version constraint

Browse Source 
Non-destructive upgrades only exist in versions >= 2.4.2
This commit is contained in:
Andrew Eisenberg
2021-02-02 08:50:45 -08:00
parent 4e94f70e6f
commit 5079abd06f
2 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
extensions/ql-vscode/CHANGELOG.md
View File

@@ -2,6 +2,8 @@
## [UNRELEASED] ## [UNRELEASED]
- Fix version constraint for flagging CLI support of non-destructive updates [#744](https://github.com/github/vscode-codeql/pull/744)
## 1.4.1 - 29 January 2021 ## 1.4.1 - 29 January 2021
- Reword the telemetry modal dialog box. [#738](https://github.com/github/vscode-codeql/pull/738) - Reword the telemetry modal dialog box. [#738](https://github.com/github/vscode-codeql/pull/738)

2
extensions/ql-vscode/src/upgrades.ts
View File

@@ -25,7 +25,7 @@ const MAX_UPGRADE_MESSAGE_LINES = 10;
* resolving upgrades. We check for a version of codeql that has all three features. * resolving upgrades. We check for a version of codeql that has all three features.
*/ */
export async function hasNondestructiveUpgradeCapabilities(qs: qsClient.QueryServerClient): Promise<boolean> { export async function hasNondestructiveUpgradeCapabilities(qs: qsClient.QueryServerClient): Promise<boolean> {
return semver.gte(await qs.cliServer.getVersion(), '2.4.1'); return semver.gte(await qs.cliServer.getVersion(), '2.4.2');
} }