mrva/vscode-codeql
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Don't use 'as any' when checking open view

Browse Source
This commit is contained in:
Charis Kyriakou
2023-09-25 09:48:57 +00:00
parent 868ffd79a5
commit 4c9ce2d537
1 changed files with 13 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
extensions/ql-vscode/src/model-editor/model-editor-view.ts
View File

@@ -1,4 +1,10 @@
import { CancellationTokenSource, Uri, ViewColumn, window } from "vscode"; import {
CancellationTokenSource,
TabInputWebview,
Uri,
ViewColumn,
window,
} from "vscode";
import { import {
AbstractWebview, AbstractWebview,
WebviewPanelConfig, WebviewPanelConfig,
@@ -151,7 +157,9 @@ export class ModelEditorView extends AbstractWebview<
private isAModelEditorOpen(): boolean { private isAModelEditorOpen(): boolean {
return window.tabGroups.all.some((tabGroup) => return window.tabGroups.all.some((tabGroup) =>
tabGroup.tabs.some((tab) => { tabGroup.tabs.some((tab) => {
const viewType: string | undefined = (tab.input as any)?.viewType; const viewType =
tab.input instanceof TabInputWebview ? tab.input.viewType : undefined;
// The viewType has a prefix, such as "mainThreadWebview-", but if the // The viewType has a prefix, such as "mainThreadWebview-", but if the
// suffix matches that should be enough to identify the view. // suffix matches that should be enough to identify the view.
return viewType && viewType.endsWith("model-editor"); return viewType && viewType.endsWith("model-editor");
@@ -162,7 +170,9 @@ export class ModelEditorView extends AbstractWebview<
private isAModelEditorActive(): boolean { private isAModelEditorActive(): boolean {
return window.tabGroups.all.some((tabGroup) => return window.tabGroups.all.some((tabGroup) =>
tabGroup.tabs.some((tab) => { tabGroup.tabs.some((tab) => {
const viewType: string | undefined = (tab.input as any)?.viewType; const viewType =
tab.input instanceof TabInputWebview ? tab.input.viewType : undefined;
// The viewType has a prefix, such as "mainThreadWebview-", but if the // The viewType has a prefix, such as "mainThreadWebview-", but if the
// suffix matches that should be enough to identify the view. // suffix matches that should be enough to identify the view.
return viewType && viewType.endsWith("model-editor") && tab.isActive; return viewType && viewType.endsWith("model-editor") && tab.isActive;