mrva/vscode-codeql
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Fix type errors

Browse Source
This commit is contained in:
Koen Vlaswinkel
2025-01-15 15:31:57 +01:00
parent 276405f743
commit 4607a452bd
2 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
extensions/ql-vscode/src/common/jsonl-reader.ts
View File

@@ -24,7 +24,12 @@ export async function readJsonlFile<T>(
return new Promise((resolve, reject) => { return new Promise((resolve, reject) => {
const stream = createReadStream(path, { encoding: "utf8" }); const stream = createReadStream(path, { encoding: "utf8" });
let buffer = ""; let buffer = "";
stream.on("data", async (chunk: string) => { stream.on("data", async (chunk: string | Buffer) => {
if (typeof chunk !== "string") {
// This should never happen because we specify the encoding as "utf8".
throw new Error("Invalid chunk");
}
const parts = (buffer + chunk).split(doubleLineBreakRegexp); const parts = (buffer + chunk).split(doubleLineBreakRegexp);
buffer = parts.pop()!; buffer = parts.pop()!;
if (parts.length > 0) { if (parts.length > 0) {

4
extensions/ql-vscode/test/vscode-tests/no-workspace/query-results.test.ts
View File

@@ -291,7 +291,7 @@ describe("query-results", () => {
}); });
const finished = new Promise((res, rej) => { const finished = new Promise((res, rej) => {
validSarifStream.addListener("close", res); validSarifStream.addListener("close", () => res(undefined));
validSarifStream.addListener("error", rej); validSarifStream.addListener("error", rej);
}); });
@@ -357,7 +357,7 @@ describe("query-results", () => {
}); });
const finished = new Promise((res, rej) => { const finished = new Promise((res, rej) => {
invalidSarifStream.addListener("close", res); invalidSarifStream.addListener("close", () => res(undefined));
invalidSarifStream.addListener("error", rej); invalidSarifStream.addListener("error", rej);
}); });