From 4009f03dd214e596723d7d0f7e62fcf150d665c8 Mon Sep 17 00:00:00 2001 From: Robert Date: Tue, 17 Jan 2023 15:49:50 +0000 Subject: [PATCH] Send telementry on other links and UI elements --- .../ql-vscode/src/view/results/RawTableHeader.tsx | 2 ++ .../ql-vscode/src/view/results/result-table-utils.tsx | 10 +++++++++- .../ql-vscode/src/view/results/result-tables.tsx | 2 ++ 3 files changed, 13 insertions(+), 1 deletion(-) diff --git a/extensions/ql-vscode/src/view/results/RawTableHeader.tsx b/extensions/ql-vscode/src/view/results/RawTableHeader.tsx index d9aea703a..59712f445 100644 --- a/extensions/ql-vscode/src/view/results/RawTableHeader.tsx +++ b/extensions/ql-vscode/src/view/results/RawTableHeader.tsx @@ -4,6 +4,7 @@ import { vscode } from "../vscode-api"; import { RawResultsSortState, SortDirection } from "../../pure/interface-types"; import { nextSortDirection } from "./result-table-utils"; import { Column } from "../../pure/bqrs-cli-types"; +import { sendTelemetry } from "../common/telemetry"; interface Props { readonly columns: readonly Column[]; @@ -39,6 +40,7 @@ function toggleSortStateForColumn( resultSetName: schemaName, sortState: nextSortState, }); + sendTelemetry("local-results-column-sorting"); } export default function RawTableHeader(props: Props) { diff --git a/extensions/ql-vscode/src/view/results/result-table-utils.tsx b/extensions/ql-vscode/src/view/results/result-table-utils.tsx index 417667177..af1037dd1 100644 --- a/extensions/ql-vscode/src/view/results/result-table-utils.tsx +++ b/extensions/ql-vscode/src/view/results/result-table-utils.tsx @@ -10,6 +10,7 @@ import { import { assertNever } from "../../pure/helpers-pure"; import { vscode } from "../vscode-api"; import { convertNonPrintableChars } from "../../text-utils"; +import { sendTelemetry } from "../common/telemetry"; export interface ResultTableProps { resultSet: ResultSet; @@ -160,13 +161,20 @@ export function nextSortDirection( } } +function sendCodeQLLanguageGuidesTelemetry() { + sendTelemetry("codeql-language-guides-link"); +} + export function emptyQueryResultsMessage(): JSX.Element { return (
This query returned no results. If this isn't what you were expecting, and for effective query-writing tips, check out the{" "} - + CodeQL language guides . diff --git a/extensions/ql-vscode/src/view/results/result-tables.tsx b/extensions/ql-vscode/src/view/results/result-tables.tsx index 6d9bc55af..43de84f9f 100644 --- a/extensions/ql-vscode/src/view/results/result-tables.tsx +++ b/extensions/ql-vscode/src/view/results/result-tables.tsx @@ -154,6 +154,7 @@ export class ResultTables extends React.Component< pageNumber: 0, selectedTable, }); + sendTelemetry("local-results-table-selection"); }; private alertTableExtras(): JSX.Element | undefined { @@ -261,6 +262,7 @@ export class ResultTables extends React.Component< const openQuery = () => { openFile(this.props.queryPath); + sendTelemetry("local-results-open-query-file"); }; const fileName = FILE_PATH_REGEX.exec(this.props.queryPath)?.[1] || "query";