mrva/vscode-codeql
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Trim whitespace and slashes in pack names

Browse Source
This commit is contained in:
Koen Vlaswinkel
2024-04-10 15:08:35 +02:00
parent bf9bfb13b7
commit 3f4ed48787
2 changed files with 23 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
extensions/ql-vscode/src/model-editor/extension-pack-name.ts
View File

@@ -17,6 +17,17 @@ export function formatPackName(packName: ExtensionPackName): string {
export function sanitizePackName(userPackName: string): ExtensionPackName { export function sanitizePackName(userPackName: string): ExtensionPackName {
let packName = userPackName; let packName = userPackName;
packName = packName.trim();
while (packName.startsWith("/")) {
packName = packName.slice(1);
}
while (packName.endsWith("/")) {
packName = packName.slice(0, -1);
}
if (!packName.includes("/")) { if (!packName.includes("/")) {
packName = `pack/${packName}`; packName = `pack/${packName}`;
} }

12
extensions/ql-vscode/test/unit-tests/model-editor/extension-pack-name.test.ts
View File

@@ -58,6 +58,18 @@ describe("sanitizePackName", () => {
name: "a/b--d--e-d-csharp", name: "a/b--d--e-d-csharp",
expected: "a/b-d-e-d-csharp", expected: "a/b-d-e-d-csharp",
}, },
{
name: "/github/vscode-codeql",
expected: "github/vscode-codeql",
},
{
name: "github/vscode-codeql/",
expected: "github/vscode-codeql",
},
{
name: "///github/vscode-codeql///",
expected: "github/vscode-codeql",
},
]; ];
test.each(testCases)( test.each(testCases)(