mrva/vscode-codeql
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Merge pull request #2425 from github/aeisenberg/truncated-log-msg

Browse Source 
Ensure full stack traces are included in log messages
This commit is contained in:
Andrew Eisenberg
2023-05-17 08:51:35 -07:00
committed by GitHub
parent 0f1f00dfc8 4ad3f7cb1f
commit 3ebd13df57
3 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
extensions/ql-vscode/CHANGELOG.md
View File

@@ -3,6 +3,7 @@
## [UNRELEASED] ## [UNRELEASED]
- Add settings `codeQL.variantAnalysis.defaultResultsFilter` and `codeQL.variantAnalysis.defaultResultsSort` for configuring how variant analysis results are filtered and sorted in the results view. The default is to show all repositories, and to sort by the number of results. [#2392](https://github.com/github/vscode-codeql/pull/2392) - Add settings `codeQL.variantAnalysis.defaultResultsFilter` and `codeQL.variantAnalysis.defaultResultsSort` for configuring how variant analysis results are filtered and sorted in the results view. The default is to show all repositories, and to sort by the number of results. [#2392](https://github.com/github/vscode-codeql/pull/2392)
- Fix bug to ensure error messages have complete stack trace in message logs. [#2425](https://github.com/github/vscode-codeql/pull/2425)
- Fix bug where the `CodeQL: Compare Query` command did not work for comparing quick-eval queries. [#2422](https://github.com/github/vscode-codeql/pull/2422) - Fix bug where the `CodeQL: Compare Query` command did not work for comparing quick-eval queries. [#2422](https://github.com/github/vscode-codeql/pull/2422)
## 1.8.4 - 3 May 2023 ## 1.8.4 - 3 May 2023

2
extensions/ql-vscode/src/common/vscode/commands.ts
View File

@@ -49,7 +49,6 @@ export function registerCommandWithErrorHandling(
const errorMessage = redactableError(error)`${ const errorMessage = redactableError(error)`${
getErrorMessage(e) || e getErrorMessage(e) || e
} (${commandId})`; } (${commandId})`;
const errorStack = getErrorStack(e);
if (e instanceof UserCancellationException) { if (e instanceof UserCancellationException) {
// User has cancelled this action manually // User has cancelled this action manually
if (e.silent) { if (e.silent) {
@@ -61,6 +60,7 @@ export function registerCommandWithErrorHandling(
} }
} else { } else {
// Include the full stack in the error log only. // Include the full stack in the error log only.
const errorStack = getErrorStack(e);
const fullMessage = errorStack const fullMessage = errorStack
? `${errorMessage.fullMessage}\n${errorStack}` ? `${errorMessage.fullMessage}\n${errorStack}`
: errorMessage.fullMessage; : errorMessage.fullMessage;

2
extensions/ql-vscode/src/helpers.ts
View File

@@ -98,7 +98,7 @@ export async function showAndLogErrorMessage(
return internalShowAndLog( return internalShowAndLog(
dropLinesExceptInitial(message), dropLinesExceptInitial(message),
Window.showErrorMessage, Window.showErrorMessage,
options, { fullMessage: message, ...options },
); );
} }