- {viewState?.extensionPack && (
- <>
-
-
- {viewState.extensionPack.name}
-
- >
- )}
+
+
+ {viewState.extensionPack.name}
+
{percentFormatter.format(modeledPercentage / 100)} modeled
{percentFormatter.format(unModeledPercentage / 100)} unmodeled
- {viewState?.enableFrameworkMode && (
+ {viewState.enableFrameworkMode && (
<>
Mode:{" "}
- {viewState?.mode === Mode.Framework
+ {viewState.mode === Mode.Framework
? "Framework"
: "Application"}
@@ -290,17 +297,17 @@ export function DataExtensionsEditor({
Apply
- {viewState?.enableFrameworkMode && (
+ {viewState.enableFrameworkMode && (
Refresh
)}
- {viewState?.mode === Mode.Framework
+ {viewState.mode === Mode.Framework
? "Generate"
: "Download and generate"}
- {viewState?.showLlmButton && (
+ {viewState.showLlmButton && (
<>
Generate using LLM
@@ -313,7 +320,6 @@ export function DataExtensionsEditor({
unsavedModels={unsavedModels}
modeledMethods={modeledMethods}
viewState={viewState}
- mode={viewState?.mode ?? Mode.Application}
onChange={onChange}
onSaveModelClick={onSaveModelClick}
onGenerateFromLlmClick={onGenerateFromLlmClick}
diff --git a/extensions/ql-vscode/src/view/data-extensions-editor/LibraryRow.tsx b/extensions/ql-vscode/src/view/data-extensions-editor/LibraryRow.tsx
index 58d8f16cf..89e50a30c 100644
--- a/extensions/ql-vscode/src/view/data-extensions-editor/LibraryRow.tsx
+++ b/extensions/ql-vscode/src/view/data-extensions-editor/LibraryRow.tsx
@@ -70,8 +70,7 @@ type Props = {
title: string;
externalApiUsages: ExternalApiUsage[];
modeledMethods: Record;
- viewState: DataExtensionEditorViewState | undefined;
- mode: Mode;
+ viewState: DataExtensionEditorViewState;
hasUnsavedChanges: boolean;
onChange: (
modelName: string,
@@ -95,7 +94,6 @@ export const LibraryRow = ({
externalApiUsages,
modeledMethods,
viewState,
- mode,
hasUnsavedChanges,
onChange,
onSaveModelClick,
@@ -166,7 +164,7 @@ export const LibraryRow = ({
{hasUnsavedChanges ? UNSAVED : null}
- {viewState?.showLlmButton && (
+ {viewState.showLlmButton && (
Model with AI
@@ -176,8 +174,8 @@ export const LibraryRow = ({
Model from source
- {viewState?.enableFrameworkMode &&
- viewState?.mode === Mode.Application && (
+ {viewState.enableFrameworkMode &&
+ viewState.mode === Mode.Application && (
Model dependency
@@ -190,7 +188,7 @@ export const LibraryRow = ({
diff --git a/extensions/ql-vscode/src/view/data-extensions-editor/ModeledMethodsList.tsx b/extensions/ql-vscode/src/view/data-extensions-editor/ModeledMethodsList.tsx
index 18ff58709..a70cbc84f 100644
--- a/extensions/ql-vscode/src/view/data-extensions-editor/ModeledMethodsList.tsx
+++ b/extensions/ql-vscode/src/view/data-extensions-editor/ModeledMethodsList.tsx
@@ -3,7 +3,6 @@ import { useMemo } from "react";
import { ExternalApiUsage } from "../../data-extensions-editor/external-api-usage";
import { ModeledMethod } from "../../data-extensions-editor/modeled-method";
import { LibraryRow } from "./LibraryRow";
-import { Mode } from "../../data-extensions-editor/shared/mode";
import {
groupMethods,
sortGroupNames,
@@ -14,8 +13,7 @@ type Props = {
externalApiUsages: ExternalApiUsage[];
unsavedModels: Set;
modeledMethods: Record;
- viewState: DataExtensionEditorViewState | undefined;
- mode: Mode;
+ viewState: DataExtensionEditorViewState;
onChange: (
modelName: string,
externalApiUsage: ExternalApiUsage,
@@ -38,15 +36,14 @@ export const ModeledMethodsList = ({
unsavedModels,
modeledMethods,
viewState,
- mode,
onChange,
onSaveModelClick,
onGenerateFromLlmClick,
onGenerateFromSourceClick,
}: Props) => {
const grouped = useMemo(
- () => groupMethods(externalApiUsages, mode),
- [externalApiUsages, mode],
+ () => groupMethods(externalApiUsages, viewState.mode),
+ [externalApiUsages, viewState.mode],
);
const sortedGroupNames = useMemo(() => sortGroupNames(grouped), [grouped]);
@@ -61,7 +58,6 @@ export const ModeledMethodsList = ({
hasUnsavedChanges={unsavedModels.has(libraryName)}
modeledMethods={modeledMethods}
viewState={viewState}
- mode={mode}
onChange={onChange}
onSaveModelClick={onSaveModelClick}
onGenerateFromLlmClick={onGenerateFromLlmClick}