diff --git a/extensions/ql-vscode/src/view/common/FileCodeSnippet/CodeSnippetMessage.tsx b/extensions/ql-vscode/src/view/common/FileCodeSnippet/CodeSnippetMessage.tsx index f60c666cc..dade5e036 100644 --- a/extensions/ql-vscode/src/view/common/FileCodeSnippet/CodeSnippetMessage.tsx +++ b/extensions/ql-vscode/src/view/common/FileCodeSnippet/CodeSnippetMessage.tsx @@ -50,6 +50,8 @@ type CodeSnippetMessageProps = { children: React.ReactNode; }; +const sendAlertMessageLinkTelemetry = () => sendTelemetry("alert-message-link"); + export const CodeSnippetMessage = ({ message, severity, @@ -66,7 +68,7 @@ export const CodeSnippetMessage = ({ return ( sendTelemetry("alert-message-link")} + onClick={sendAlertMessageLinkTelemetry} href={createRemoteFileRef( token.location.fileLink, token.location.highlightedRegion?.startLine, diff --git a/extensions/ql-vscode/src/view/common/FileCodeSnippet/FileCodeSnippet.tsx b/extensions/ql-vscode/src/view/common/FileCodeSnippet/FileCodeSnippet.tsx index 801b6f93f..444dea093 100644 --- a/extensions/ql-vscode/src/view/common/FileCodeSnippet/FileCodeSnippet.tsx +++ b/extensions/ql-vscode/src/view/common/FileCodeSnippet/FileCodeSnippet.tsx @@ -47,6 +47,9 @@ type Props = { messageChildren?: React.ReactNode; }; +const sendCodeSnippetTitleLinkTelemetry = () => + sendTelemetry("file-code-snippet-title-link"); + export const FileCodeSnippet = ({ fileLink, codeSnippet, @@ -69,7 +72,7 @@ export const FileCodeSnippet = ({ sendTelemetry("file-code-snippet-title-link")} + onClick={sendCodeSnippetTitleLinkTelemetry} href={titleFileUri} > {fileLink.filePath} @@ -90,7 +93,7 @@ export const FileCodeSnippet = ({ sendTelemetry("file-code-snippet-title-link")} + onClick={sendCodeSnippetTitleLinkTelemetry} href={titleFileUri} > {fileLink.filePath} diff --git a/extensions/ql-vscode/src/view/remote-queries/RawResultsTable.tsx b/extensions/ql-vscode/src/view/remote-queries/RawResultsTable.tsx index 838c27375..9ef6ce1c5 100644 --- a/extensions/ql-vscode/src/view/remote-queries/RawResultsTable.tsx +++ b/extensions/ql-vscode/src/view/remote-queries/RawResultsTable.tsx @@ -45,6 +45,8 @@ type CellProps = { sourceLocationPrefix: string; }; +const sendRawResultsLinkTelemetry = () => sendTelemetry("raw-results-link"); + const Cell = ({ value, fileLinkPrefix, sourceLocationPrefix }: CellProps) => { switch (typeof value) { case "string": @@ -60,10 +62,7 @@ const Cell = ({ value, fileLinkPrefix, sourceLocationPrefix }: CellProps) => { const safeLabel = convertNonPrintableChars(value.label); if (url) { return ( - sendTelemetry("raw-results-link")} - href={url} - > + {safeLabel} );