mrva/vscode-codeql
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Small cleanup and comment

Browse Source
This commit is contained in:
Andrew Eisenberg
2022-02-23 09:52:46 -08:00
parent f0354c87f4
commit 1ed8b225db
2 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
extensions/ql-vscode/src/remote-queries/analyses-results-manager.ts
View File

@@ -80,7 +80,11 @@ export class AnalysesResultsManager {
} }
public getAnalysesResults(queryId: string): AnalysisResults[] { public getAnalysesResults(queryId: string): AnalysisResults[] {
return [...(this.analysesResults.get(queryId) || [])]; return [...this.internalGetAnalysesResults(queryId)];
}
private internalGetAnalysesResults(queryId: string): AnalysisResults[] {
return this.analysesResults.get(queryId) || [];
} }
public removeAnalysesResults(queryId: string) { public removeAnalysesResults(queryId: string) {
@@ -98,7 +102,7 @@ export class AnalysesResultsManager {
results: [] results: []
}; };
const queryId = analysis.downloadLink.queryId; const queryId = analysis.downloadLink.queryId;
const resultsForQuery = this.analysesResults.get(queryId) || []; const resultsForQuery = this.internalGetAnalysesResults(queryId);
resultsForQuery.push(analysisResults); resultsForQuery.push(analysisResults);
this.analysesResults.set(queryId, resultsForQuery); this.analysesResults.set(queryId, resultsForQuery);
void publishResults(resultsForQuery); void publishResults(resultsForQuery);
@@ -146,6 +150,6 @@ export class AnalysesResultsManager {
} }
private isAnalysisDownloaded(analysis: AnalysisSummary): boolean { private isAnalysisDownloaded(analysis: AnalysisSummary): boolean {
return (this.analysesResults.get(analysis.downloadLink.queryId) || []).some(x => x.nwo === analysis.nwo); return this.internalGetAnalysesResults(analysis.downloadLink.queryId).some(x => x.nwo === analysis.nwo);
} }
} }

1
extensions/ql-vscode/src/remote-queries/run-remote-query.ts
View File

@@ -302,6 +302,7 @@ export async function runRemoteQuery(
message: 'Sending request' message: 'Sending request'
}); });
// TODO When https://github.com/dsp-testing/qc-run2/pull/567 is merged, we can change the branch back to `main`.
const workflowRunId = await runRemoteQueriesApiRequest(credentials, 'better-errors', language, repositories, owner, repo, base64Pack, dryRun); const workflowRunId = await runRemoteQueriesApiRequest(credentials, 'better-errors', language, repositories, owner, repo, base64Pack, dryRun);
const queryStartTime = Date.now(); const queryStartTime = Date.now();
const queryMetadata = await tryGetQueryMetadata(cliServer, queryFile); const queryMetadata = await tryGetQueryMetadata(cliServer, queryFile);