mrva/vscode-codeql
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Clean up temporary file in finally block

Browse Source
This commit is contained in:
Koen Vlaswinkel
2024-03-11 14:39:07 +01:00
parent 35267bb3fd
commit 0feef365d9
1 changed files with 12 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
extensions/ql-vscode/src/variant-analysis/code-scanning-pack.ts
View File

@@ -29,10 +29,6 @@ export async function resolveCodeScanningQueryPack(
// Resolve queries // Resolve queries
void logger.log(`Resolving queries for pack: ${packName}`); void logger.log(`Resolving queries for pack: ${packName}`);
const suiteFile = await file({
postfix: ".qls",
});
const suitePath = suiteFile.path;
const suiteYaml: SuiteInstruction[] = [ const suiteYaml: SuiteInstruction[] = [
{ {
import: `codeql-suites/${language}-code-scanning.qls`, import: `codeql-suites/${language}-code-scanning.qls`,
@@ -45,11 +41,20 @@ export async function resolveCodeScanningQueryPack(
}, },
}, },
]; ];
await outputFile(suitePath, dump(suiteYaml), "utf8");
const resolvedQueries = await cliServer.resolveQueries(suitePath); let resolvedQueries: string[];
const suiteFile = await file({
postfix: ".qls",
});
const suitePath = suiteFile.path;
await suiteFile.cleanup(); try {
await outputFile(suitePath, dump(suiteYaml), "utf8");
resolvedQueries = await cliServer.resolveQueries(suitePath);
} finally {
await suiteFile.cleanup();
}
if (resolvedQueries.length === 0) { if (resolvedQueries.length === 0) {
throw Error( throw Error(