mrva/vscode-codeql
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Merge pull request #1828 from github/koesie10/results-loading

Browse Source 
Add spinner when loading results
This commit is contained in:
Koen Vlaswinkel
2022-12-07 16:46:20 +01:00
committed by GitHub
parent 3dd0ef50e0 51d3a018de
commit 0f5117ecec
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
extensions/ql-vscode/src/view/variant-analysis/RepoRow.tsx
View File

@@ -227,7 +227,7 @@ export const RepoRow = ({
[onSelectedChange, repository], [onSelectedChange, repository],
); );
const disabled = !canExpand(status, downloadStatus); const disabled = !canExpand(status, downloadStatus) || resultsLoading;
const expandableContentLoaded = isExpandableContentLoaded( const expandableContentLoaded = isExpandableContentLoaded(
status, status,
downloadStatus, downloadStatus,
@@ -247,11 +247,13 @@ export const RepoRow = ({
checked={selected} checked={selected}
disabled={!repository.id || !canSelect(status, downloadStatus)} disabled={!repository.id || !canSelect(status, downloadStatus)}
/> />
{isExpanded ? ( {isExpanded && (
<ExpandCollapseCodicon name="chevron-down" label="Collapse" /> <ExpandCollapseCodicon name="chevron-down" label="Collapse" />
) : ( )}
{!isExpanded && !resultsLoading && (
<ExpandCollapseCodicon name="chevron-right" label="Expand" /> <ExpandCollapseCodicon name="chevron-right" label="Expand" />
)} )}
{resultsLoading && <LoadingIcon label="Results are loading" />}
<VSCodeBadge> <VSCodeBadge>
{resultCount === undefined ? "-" : formatDecimal(resultCount)} {resultCount === undefined ? "-" : formatDecimal(resultCount)}
</VSCodeBadge> </VSCodeBadge>