From 0ecde78d6efb3e61508f3cb48615b77634428dda Mon Sep 17 00:00:00 2001 From: Andrew Eisenberg Date: Mon, 6 Mar 2023 18:01:37 -0800 Subject: [PATCH] Fix test comments --- .vscode/settings.json | 12 ++++++++---- .../vscode-tests/cli-integration/queries.test.ts | 4 ++-- 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/.vscode/settings.json b/.vscode/settings.json index 41bad73a9..6bc3c9dde 100644 --- a/.vscode/settings.json +++ b/.vscode/settings.json @@ -45,22 +45,26 @@ // These options are used by the `jestrunner.debug` command. // They are not used by the `jestrunner.run` command. + // After clicking "debug" over a test, continually invoke the + // "Debug: Attach to Node Process" command until you see a + // process named "Code Helper (Plugin)". Then click "attach". + // This will attach the debugger to the test process. "jestrunner.debugOptions": { // Uncomment to debug integration tests - // "attachSimplePort": 9223, + "attachSimplePort": 9223, "env": { "LANG": "en-US", "TZ": "UTC", // Uncomment to set a custom path to a CodeQL checkout. - // "TEST_CODEQL_PATH": "../codeql", + // "TEST_CODEQL_PATH": "/absolute/path/to/checkout/of/codeql", // Uncomment to set a custom path to a CodeQL CLI executable. // This is the CodeQL version that will be used in the tests. - // "CLI_PATH": "/path/to/customg/codeql", + // "CLI_PATH": "/absolute/path/to/custom/codeql", // Uncomment to debug integration tests - // "VSCODE_WAIT_FOR_DEBUGGER": "true", + "VSCODE_WAIT_FOR_DEBUGGER": "true", } }, "terminal.integrated.env.linux": { diff --git a/extensions/ql-vscode/test/vscode-tests/cli-integration/queries.test.ts b/extensions/ql-vscode/test/vscode-tests/cli-integration/queries.test.ts index 4e63fb288..65b304235 100644 --- a/extensions/ql-vscode/test/vscode-tests/cli-integration/queries.test.ts +++ b/extensions/ql-vscode/test/vscode-tests/cli-integration/queries.test.ts @@ -110,7 +110,7 @@ describeWithCodeQL()("Queries", () => { it("should run a query that has an extension without looking for extensions in the workspace", async () => { if (!(await supportsExtensionPacks())) { console.log( - `Skipping test because it is only supported for CodeQL CLI versions < ${CliVersionConstraint.CLI_VERSION_WITH_QLPACKS_KIND}`, + `Skipping test because it is only supported for CodeQL CLI versions >= ${CliVersionConstraint.CLI_VERSION_WITH_QLPACKS_KIND}`, ); return; } @@ -135,7 +135,7 @@ describeWithCodeQL()("Queries", () => { return true; } console.log( - `Skipping test because it is only supported for CodeQL CLI versions < ${CliVersionConstraint.CLI_VERSION_WITH_QLPACKS_KIND}`, + `Skipping test because it is only supported for CodeQL CLI versions >= ${CliVersionConstraint.CLI_VERSION_WITH_QLPACKS_KIND}`, ); return false; }