From 0a304f633a7f2be35182f962e434eb5c6a1540b8 Mon Sep 17 00:00:00 2001 From: Koen Vlaswinkel Date: Thu, 13 Apr 2023 15:01:43 +0200 Subject: [PATCH] Use enum for query texts --- .../src/data-extensions-editor/external-api-usage-query.ts | 3 ++- .../ql-vscode/src/data-extensions-editor/queries/index.ts | 5 +++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/extensions/ql-vscode/src/data-extensions-editor/external-api-usage-query.ts b/extensions/ql-vscode/src/data-extensions-editor/external-api-usage-query.ts index 7ad472d31..2f0b28561 100644 --- a/extensions/ql-vscode/src/data-extensions-editor/external-api-usage-query.ts +++ b/extensions/ql-vscode/src/data-extensions-editor/external-api-usage-query.ts @@ -15,6 +15,7 @@ import { fetchExternalApiQueries } from "./queries"; import { QueryResultType } from "../pure/new-messages"; import { join } from "path"; import { redactableError } from "../pure/errors"; +import { QueryLanguage } from "../common/query-language"; export type RunQueryOptions = { cliServer: Pick; @@ -40,7 +41,7 @@ export async function runQuery({ // For a reference of what this should do in the future, see the previous implementation in // https://github.com/github/vscode-codeql/blob/089d3566ef0bc67d9b7cc66e8fd6740b31c1c0b0/extensions/ql-vscode/src/data-extensions-editor/external-api-usage-query.ts#L33-L72 - const query = fetchExternalApiQueries[databaseItem.language]; + const query = fetchExternalApiQueries[databaseItem.language as QueryLanguage]; if (!query) { void showAndLogExceptionWithTelemetry( redactableError`No external API usage query found for language ${databaseItem.language}`, diff --git a/extensions/ql-vscode/src/data-extensions-editor/queries/index.ts b/extensions/ql-vscode/src/data-extensions-editor/queries/index.ts index 7f5864bb9..5f864ff03 100644 --- a/extensions/ql-vscode/src/data-extensions-editor/queries/index.ts +++ b/extensions/ql-vscode/src/data-extensions-editor/queries/index.ts @@ -1,6 +1,7 @@ import { fetchExternalApisQuery as javaFetchExternalApisQuery } from "./java"; import { Query } from "./query"; +import { QueryLanguage } from "../../common/query-language"; -export const fetchExternalApiQueries: Record = { - java: javaFetchExternalApisQuery, +export const fetchExternalApiQueries: Partial> = { + [QueryLanguage.Java]: javaFetchExternalApisQuery, };