wip: Make cross-module visibility explicit via Visibles structs

All access is/will be through interfaces accessed through these structs.

This introduces several distinct storage units:
+ DB for server state
+ DB for codeql databases
+ query pack store

The steps for manually creating needed databases are in the README

pkg/server/server.go

@@ -21,7 +21,7 @@ import (
 	"github.com/gorilla/mux"
 )
 
-func (c *CommanderSingle) Setup(st *State) {
+func (c *CommanderSingle) Setup(st *CommanderVisibles) {
 	r := mux.NewRouter()
 	c.st = st
 
@@ -275,7 +275,7 @@ func (c *CommanderSingle) MirvaRequest(w http.ResponseWriter, r *http.Request) {
 	vars := mux.Vars(r)
 	slog.Info("New mrva run ", "owner", vars["owner"], "repo", vars["repo"])
 
-	session_id := c.st.Storage.NextID()
+	session_id := c.st.ServerStore.NextID()
 	session_owner := vars["owner"]
 	session_controller_repo := vars["repo"]
 	slog.Info("new run", "id: ", fmt.Sprint(session_id), session_owner, session_controller_repo)
@@ -284,7 +284,7 @@ func (c *CommanderSingle) MirvaRequest(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 
-	not_found_repos, analysisRepos := c.st.Storage.FindAvailableDBs(session_repositories)
+	not_found_repos, analysisRepos := c.st.ServerStore.FindAvailableDBs(session_repositories)
 
 	c.queue.StartAnalyses(analysisRepos, session_id, session_language)
 
@@ -492,7 +492,7 @@ func (c *CommanderSingle) extract_tgz(qp string, sessionID int) (string, error)
 		return "", err
 	}
 
-	session_query_pack_tgz_filepath, err := c.st.Storage.SaveQueryPack(tgz, sessionID)
+	session_query_pack_tgz_filepath, err := c.st.ServerStore.SaveQueryPack(tgz, sessionID)
 	if err != nil {
 		return "", err
 	}

pkg/server/types.go

@@ -1,7 +1,6 @@
 package server
 
 import (
-	"mrvacommander/pkg/agent"
 	"mrvacommander/pkg/common"
 	"mrvacommander/pkg/logger"
 	"mrvacommander/pkg/queue"
@@ -26,19 +25,30 @@ type SessionInfo struct {
 }
 
 type CommanderSingle struct {
-	st    *State
+	st *CommanderVisibles
+	// TODO remove:
 	queue queue.Queue
 }
 
-func NewCommanderSingle(s *State, q queue.Queue) *CommanderSingle {
+func NewCommanderSingle(s *CommanderVisibles, q queue.Queue) *CommanderSingle {
 	c := CommanderSingle{s, q}
 	return &c
 }
 
-type State struct {
-	Commander Commander
-	Logger    logger.Logger
-	Queue     queue.Queue
-	Storage   storage.Storage
-	Runner    agent.Runner
+// type State struct {
+// 	Commander Commander
+// 	Logger    logger.Logger
+// 	Queue     queue.Queue
+// 	Storage   storage.Storage
+// 	Runner    agent.Runner
+// }
+
+type CommanderVisibles struct {
+	Logger      logger.Logger
+	Queue       queue.Queue
+	ServerStore storage.Storage
+	// TODO extra package for query pack storage
+	QueryPackStore storage.Storage
+	// TODO extra package for ql db storage
+	QLDBStore storage.Storage
 }