Type checking fix: Restrict the keys / values for ArtifactLocation and centralize the common ones

pkg/qldbstore/interfaces.go

@@ -8,6 +8,7 @@ type CodeQLDatabaseLocation struct {
 	// `data` is a map of key-value pairs that describe the location of the database.
 	// For example, a simple key-value pair could be "path" -> "/path/to/database.zip".
 	// A more complex implementation could be "bucket" -> "example", "key" -> "unique_identifier".
+	// XX: static types
 	data map[string]string
 }
 

pkg/qldbstore/qldbstore_minio.go

@@ -5,6 +5,7 @@ import (
 	"fmt"
 	"io"
 	"log/slog"
+	"mrvacommander/pkg/artifactstore"
 	"mrvacommander/pkg/common"
 
 	"github.com/minio/minio-go/v7"
@@ -58,8 +59,8 @@ func (store *MinIOCodeQLDatabaseStore) FindAvailableDBs(analysisReposRequested [
 }
 
 func (store *MinIOCodeQLDatabaseStore) GetDatabase(location CodeQLDatabaseLocation) ([]byte, error) {
-	bucket := location.data["bucket"]
-	key := location.data["key"]
+	bucket := location.data[artifactstore.AF_KEY_BUCKET]
+	key := location.data[artifactstore.AF_KEY_KEY]
 
 	object, err := store.client.GetObject(context.Background(), bucket, key, minio.GetObjectOptions{})
 	if err != nil {