mirror of
https://github.com/github/codeql.git
synced 2025-12-24 12:46:34 +01:00
30 lines
919 B
Plaintext
30 lines
919 B
Plaintext
/**
|
|
* @name Duplicate function
|
|
* @description There is another function that shares a lot of code with this function.
|
|
* Extract the common parts to a shared utility function to improve maintainability.
|
|
* @kind problem
|
|
* @problem.severity recommendation
|
|
* @id js/duplicate-function
|
|
* @tags testability
|
|
* useless-code
|
|
* maintainability
|
|
* statistical
|
|
* non-attributable
|
|
* duplicate-code
|
|
* @precision medium
|
|
*/
|
|
|
|
import javascript
|
|
import CodeDuplication
|
|
import semmle.javascript.RestrictedLocations
|
|
|
|
from Function f, Function g, float percent
|
|
where
|
|
duplicateContainers(f, g, percent) and
|
|
f.getNumBodyStmt() > 5 and
|
|
not duplicateContainers(f.getEnclosingStmt().getContainer(), g.getEnclosingStmt().getContainer(),
|
|
_)
|
|
select f.(FirstLineOf),
|
|
percent.floor() + "% of statements in " + f.describe() + " are duplicated in $@.",
|
|
g.(FirstLineOf), g.describe()
|