mirror of
https://github.com/github/codeql.git
synced 2026-06-17 10:51:09 +02:00
1b1095ee75
Flow from a definition by reference of a field into its object was working inconsistently and in a very syntax-dependent way. For a function `f` receiving a reference, `f(a->x)` could propagate data back to `a` via the _reverse read_ mechanism in the shared data-flow library, but for a function `g` receiving a pointer, `g(&a->x)` would not work. And `f((*a).x)` would not work either. In all cases, the issue was that the shared data-flow library propagates data backwards between `PostUpdateNode`s only, but there is no `PostUpdateNode` for `a->x` in `g(&a->x)`. This pull request inserts such post-update nodes where appropriate and links them to their neighbors. In this exapmle, flow back from the output parameter of `g` passes first to the `PostUpdateNode` of `&`, then to the (new) `PostUpdateNode` of `a->x`, and finally, as a _reverse read_ with the appropriate field projection, to `a`.
60 lines
3.4 KiB
Plaintext
60 lines
3.4 KiB
Plaintext
uniqueEnclosingCallable
|
|
| C.cpp:37:24:37:33 | 0 | Node should have one enclosing callable but has 0. |
|
|
| C.cpp:37:24:37:33 | new | Node should have one enclosing callable but has 0. |
|
|
uniqueTypeBound
|
|
| complex.cpp:22:11:22:17 | constructor init of field f [post-this] | Node should have one type bound but has 0. |
|
|
| complex.cpp:22:11:22:17 | constructor init of field f [pre-this] | Node should have one type bound but has 0. |
|
|
uniqueTypeRepr
|
|
| complex.cpp:22:11:22:17 | constructor init of field f [post-this] | Node should have one type representation but has 0. |
|
|
| complex.cpp:22:11:22:17 | constructor init of field f [pre-this] | Node should have one type representation but has 0. |
|
|
uniqueNodeLocation
|
|
| A.cpp:38:7:38:8 | call to C | Node should have one location but has 2. |
|
|
| A.cpp:39:7:39:8 | call to C | Node should have one location but has 2. |
|
|
| A.cpp:41:15:41:21 | call to C | Node should have one location but has 2. |
|
|
| A.cpp:47:12:47:18 | call to C | Node should have one location but has 2. |
|
|
| A.cpp:57:17:57:23 | call to C | Node should have one location but has 2. |
|
|
| A.cpp:64:21:64:28 | call to C2 | Node should have one location but has 2. |
|
|
| A.cpp:73:25:73:32 | call to C2 | Node should have one location but has 2. |
|
|
| A.cpp:126:12:126:18 | call to C | Node should have one location but has 2. |
|
|
| A.cpp:142:14:142:20 | call to C | Node should have one location but has 2. |
|
|
| file://:0:0:0:0 | call to C | Node should have one location but has 2. |
|
|
| file://:0:0:0:0 | call to C | Node should have one location but has 2. |
|
|
| file://:0:0:0:0 | call to C | Node should have one location but has 2. |
|
|
| file://:0:0:0:0 | call to C | Node should have one location but has 2. |
|
|
| file://:0:0:0:0 | call to C | Node should have one location but has 2. |
|
|
| file://:0:0:0:0 | call to C | Node should have one location but has 2. |
|
|
| file://:0:0:0:0 | call to C | Node should have one location but has 2. |
|
|
| file://:0:0:0:0 | call to C2 | Node should have one location but has 2. |
|
|
| file://:0:0:0:0 | call to C2 | Node should have one location but has 2. |
|
|
missingLocation
|
|
uniqueNodeToString
|
|
missingToString
|
|
parameterCallable
|
|
localFlowIsLocal
|
|
compatibleTypesReflexive
|
|
unreachableNodeCCtx
|
|
localCallNodes
|
|
postIsNotPre
|
|
postHasUniquePre
|
|
uniquePostUpdate
|
|
postIsInSameCallable
|
|
reverseRead
|
|
storeIsPostUpdate
|
|
argHasPostUpdate
|
|
| A.cpp:41:15:41:21 | new | ArgumentNode is missing PostUpdateNode. |
|
|
| A.cpp:55:12:55:19 | new | ArgumentNode is missing PostUpdateNode. |
|
|
| A.cpp:57:11:57:24 | new | ArgumentNode is missing PostUpdateNode. |
|
|
| A.cpp:57:17:57:23 | new | ArgumentNode is missing PostUpdateNode. |
|
|
| A.cpp:64:21:64:28 | new | ArgumentNode is missing PostUpdateNode. |
|
|
| A.cpp:73:25:73:32 | new | ArgumentNode is missing PostUpdateNode. |
|
|
| A.cpp:126:12:126:18 | new | ArgumentNode is missing PostUpdateNode. |
|
|
| A.cpp:160:32:160:59 | new | ArgumentNode is missing PostUpdateNode. |
|
|
| D.cpp:29:24:29:40 | new | ArgumentNode is missing PostUpdateNode. |
|
|
| D.cpp:36:24:36:40 | new | ArgumentNode is missing PostUpdateNode. |
|
|
| D.cpp:43:24:43:40 | new | ArgumentNode is missing PostUpdateNode. |
|
|
| D.cpp:50:24:50:40 | new | ArgumentNode is missing PostUpdateNode. |
|
|
| D.cpp:57:25:57:41 | new | ArgumentNode is missing PostUpdateNode. |
|
|
| by_reference.cpp:51:8:51:8 | s | ArgumentNode is missing PostUpdateNode. |
|
|
| by_reference.cpp:57:8:57:8 | s | ArgumentNode is missing PostUpdateNode. |
|
|
| by_reference.cpp:63:8:63:8 | s | ArgumentNode is missing PostUpdateNode. |
|