mirror of
https://github.com/github/codeql.git
synced 2026-05-25 08:37:20 +02:00
3448751b4c
Such that we can reuse the existing modeling, but have it globally applied as a threat-model as well. I Basically just moved the modeling. One important aspect is that this changes is that the previously query-specific `argsParseStep` is now a globally applied taint-step. This seems reasonable, if someone applied the argument parsing to any user-controlled string, it seems correct to propagate that taint for _any_ query.
32 lines
1.0 KiB
Plaintext
32 lines
1.0 KiB
Plaintext
/**
|
|
* Provides a taint-tracking configuration for reasoning about command-injection
|
|
* vulnerabilities (CWE-078).
|
|
*/
|
|
|
|
import javascript
|
|
import IndirectCommandInjectionCustomizations::IndirectCommandInjection
|
|
private import IndirectCommandArgument
|
|
|
|
/**
|
|
* A taint-tracking configuration for reasoning about command-injection vulnerabilities.
|
|
*/
|
|
class Configuration extends TaintTracking::Configuration {
|
|
Configuration() { this = "IndirectCommandInjection" }
|
|
|
|
override predicate isSource(DataFlow::Node source) { source instanceof Source }
|
|
|
|
/**
|
|
* Holds if `sink` is a data-flow sink for command-injection vulnerabilities, and
|
|
* the alert should be placed at the node `highlight`.
|
|
*/
|
|
predicate isSinkWithHighlight(DataFlow::Node sink, DataFlow::Node highlight) {
|
|
sink instanceof Sink and highlight = sink
|
|
or
|
|
isIndirectCommandArgument(sink, highlight)
|
|
}
|
|
|
|
override predicate isSink(DataFlow::Node sink) { this.isSinkWithHighlight(sink, _) }
|
|
|
|
override predicate isSanitizer(DataFlow::Node node) { node instanceof Sanitizer }
|
|
}
|