mirror of
https://github.com/github/codeql.git
synced 2026-03-05 23:26:51 +01:00
29 lines
1.0 KiB
Plaintext
29 lines
1.0 KiB
Plaintext
/**
|
|
* @name Conflicting function declarations
|
|
* @description If two functions with the same name are declared in the same scope, one of the declarations
|
|
* overrides the other without warning. This makes the code hard to read and maintain, and
|
|
* may even lead to platform-dependent behavior.
|
|
* @kind problem
|
|
* @problem.severity error
|
|
* @id js/function-declaration-conflict
|
|
* @tags reliability
|
|
* correctness
|
|
* external/cwe/cwe-563
|
|
* @precision high
|
|
*/
|
|
|
|
import javascript
|
|
|
|
from FunctionDeclStmt f, FunctionDeclStmt g
|
|
where
|
|
f.getVariable() = g.getVariable() and
|
|
// ignore global functions; conflicts across scripts are usually false positives
|
|
not f.getVariable().isGlobal() and
|
|
// only report each pair once
|
|
f.getLocation().startsBefore(g.getLocation()) and
|
|
// ignore ambient, abstract, and overloaded declarations in TypeScript
|
|
f.hasBody() and
|
|
g.hasBody()
|
|
select f.getId(), "Declaration of " + f.describe() + " conflicts with $@ in the same scope.",
|
|
g.getId(), "another declaration"
|