codeql

mirror of https://github.com/github/codeql.git synced 2026-04-29 18:55:14 +02:00

Files

Rasmus Wriedt Larsen e2de0e61ca Python: Remove RegExpTerm from PrintAST

Since this caused bad performance (as we had to evaluate points-to).

Fixes https://github.com/github/codeql/issues/6964

This approach was motivated by the comment on the issue from @tausbn:

> We discussed this internally in the CodeQL Python team, and have
> agreed that the best approach for now is to disable the printing of
> regex ASTs.

I tried to keep our RegExpTerm logic, but doing the fix below did not
work, and still evaluated RegExpTerm :| I guess we will just have to
revert this PR if we want it back

```diff
   TRegExpTermNode(RegExpTerm term) {
+    none() and
     exists(StrConst str | term.getRootTerm() = getParsedRegExp(str) and shouldPrint(str, _))
   }
```

2022-02-03 14:22:14 +01:00

change-notes

Merge branch rc/3.4 into main

2022-01-25 16:22:01 +00:00

downgrades/503c0516fba2e5da9570f00eb34ef43025ecb8fb

python: remove compiler warnings

2022-01-19 18:01:58 +01:00

semmle

Python: Remove RegExpTerm from PrintAST

2022-02-03 14:22:14 +01:00

upgrades

python: remove compiler warnings