mirror of
https://github.com/github/codeql.git
synced 2026-02-12 13:11:20 +01:00
5b63b4957c
Mostly just adding `private import LegacyPointsTo`. Sometimes getting rid of other imports that are superceded by that module.
41 lines
1.0 KiB
Plaintext
41 lines
1.0 KiB
Plaintext
/**
|
|
* @name Unused parameter
|
|
* @description Parameter is defined but not used
|
|
* @kind problem
|
|
* @tags quality
|
|
* reliability
|
|
* correctness
|
|
* readability
|
|
* @problem.severity recommendation
|
|
* @sub-severity high
|
|
* @precision medium
|
|
* @id py/unused-parameter
|
|
*/
|
|
|
|
import python
|
|
import Definition
|
|
private import LegacyPointsTo
|
|
|
|
predicate unused_parameter(FunctionValue f, LocalVariable v) {
|
|
v.isParameter() and
|
|
v.getScope() = f.getScope() and
|
|
not name_acceptable_for_unused_variable(v) and
|
|
not exists(NameNode u | u.uses(v)) and
|
|
not exists(Name inner, LocalVariable iv |
|
|
inner.uses(iv) and iv.getId() = v.getId() and inner.getScope().getScope() = v.getScope()
|
|
)
|
|
}
|
|
|
|
predicate is_abstract(FunctionValue func) {
|
|
func.getScope().getADecorator().(Name).getId().matches("%abstract%")
|
|
}
|
|
|
|
from PythonFunctionValue f, LocalVariable v
|
|
where
|
|
v.getId() != "self" and
|
|
unused_parameter(f, v) and
|
|
not f.isOverridingMethod() and
|
|
not f.isOverriddenMethod() and
|
|
not is_abstract(f)
|
|
select f, "The parameter '" + v.getId() + "' is never used."
|