mirror of
https://github.com/github/codeql.git
synced 2026-03-24 08:26:51 +01:00
f07a7bf8cf
Will need subsequent PRs fixing up test failures (due to deprecated methods moving around), but other than that everything should be straight-forward.
36 lines
1.2 KiB
Plaintext
36 lines
1.2 KiB
Plaintext
/**
|
|
* @name Signature mismatch in overriding method
|
|
* @description Overriding a method without ensuring that both methods accept the same
|
|
* number and type of parameters has the potential to cause an error when there is a mismatch.
|
|
* @kind problem
|
|
* @problem.severity warning
|
|
* @tags reliability
|
|
* correctness
|
|
* @sub-severity high
|
|
* @precision very-high
|
|
* @id py/inheritance/signature-mismatch
|
|
*/
|
|
|
|
import python
|
|
import Expressions.CallArgs
|
|
|
|
from FunctionValue base, PythonFunctionValue derived
|
|
where
|
|
not exists(base.getACall()) and
|
|
not exists(FunctionValue a_derived |
|
|
a_derived.overrides(base) and
|
|
exists(a_derived.getACall())
|
|
) and
|
|
not derived.getScope().isSpecialMethod() and
|
|
derived.getName() != "__init__" and
|
|
derived.isNormalMethod() and
|
|
not derived.getScope().isSpecialMethod() and
|
|
// call to overrides distributed for efficiency
|
|
(
|
|
derived.overrides(base) and derived.minParameters() > base.maxParameters()
|
|
or
|
|
derived.overrides(base) and derived.maxParameters() < base.minParameters()
|
|
)
|
|
select derived, "Overriding method '" + derived.getName() + "' has signature mismatch with $@.",
|
|
base, "overridden method"
|