mirror of
https://github.com/github/codeql.git
synced 2026-01-08 04:00:26 +01:00
This works by adding data-flow edges to skip over array expressions when reading from arrays. On the post-update side, there was already code to skip over array expressions when storing to arrays. That happens in `valueToUpdate` in `AddressFlow.qll`, which needed just a small tweak to support assignments with non-field expressions at the top-level LHS, like `*a = ...` or `a[0] = ...`. The new code in `AddressFlow.qll` is copy-pasted from `EscapesTree.qll`, and there is already a note in these files saying that they share a lot of code and must be maintained in sync.
328 lines
5.6 KiB
C++
328 lines
5.6 KiB
C++
|
|
#include "stl.h"
|
|
|
|
using namespace std;
|
|
|
|
int source();
|
|
|
|
namespace ns_int
|
|
{
|
|
int source();
|
|
}
|
|
|
|
void sink(int);
|
|
void sink(std::vector<int> &);
|
|
|
|
void test_range_based_for_loop_vector(int source1) {
|
|
std::vector<int> v(100, source1);
|
|
|
|
for(int x : v) {
|
|
sink(x); // tainted [NOT DETECTED by IR]
|
|
}
|
|
|
|
for(std::vector<int>::iterator it = v.begin(); it != v.end(); ++it) {
|
|
sink(*it); // tainted
|
|
}
|
|
|
|
for(int& x : v) {
|
|
sink(x); // tainted [NOT DETECTED by IR]
|
|
}
|
|
|
|
const std::vector<int> const_v(100, source1);
|
|
for(const int& x : const_v) {
|
|
sink(x); // tainted [NOT DETECTED by IR]
|
|
}
|
|
}
|
|
|
|
void test_element_taint(int x) {
|
|
std::vector<int> v1(10), v2(10), v3(10), v4(10), v5(10), v6(10), v7(10), v8(10), v9(10);
|
|
|
|
v1[0] = 0;
|
|
v1[1] = 0;
|
|
v1[x] = 0;
|
|
v1.push_back(1);
|
|
sink(v1);
|
|
sink(v1[0]);
|
|
sink(v1[1]);
|
|
sink(v1[x]);
|
|
sink(v1.front());
|
|
sink(v1.back());
|
|
|
|
v2[0] = source();
|
|
sink(v2); // tainted
|
|
sink(v2[0]); // tainted
|
|
sink(v2[1]); // [FALSE POSITIVE]
|
|
sink(v2[x]); // potentially tainted
|
|
|
|
v3 = v2;
|
|
sink(v3); // tainted
|
|
sink(v3[0]); // tainted
|
|
sink(v3[1]); // [FALSE POSITIVE]
|
|
sink(v3[x]); // potentially tainted
|
|
|
|
v4[x] = source();
|
|
sink(v4); // tainted
|
|
sink(v4[0]); // potentially tainted
|
|
sink(v4[1]); // potentially tainted
|
|
sink(v4[x]); // tainted
|
|
|
|
v5.push_back(source());
|
|
sink(v5); // tainted
|
|
sink(v5.front()); // [FALSE POSITIVE]
|
|
sink(v5.back()); // tainted
|
|
|
|
v6.data()[2] = source();
|
|
sink(v6); // tainted
|
|
sink(v6.data()[2]); // tainted
|
|
|
|
|
|
{
|
|
std::vector<int>::const_iterator it = v7.begin();
|
|
v7.insert(it, source());
|
|
}
|
|
sink(v7); // tainted
|
|
sink(v7.front()); // tainted
|
|
sink(v7.back()); // [FALSE POSITIVE]
|
|
|
|
{
|
|
const std::vector<int> &v8c = v8;
|
|
std::vector<int>::const_iterator it = v8c.begin();
|
|
v8.insert(it, 10, ns_int::source());
|
|
}
|
|
sink(v8); // tainted [NOT DETECTED]
|
|
sink(v8.front()); // tainted [NOT DETECTED]
|
|
sink(v8.back());
|
|
|
|
v9.at(x) = source();
|
|
sink(v9); // tainted
|
|
sink(v9.at(0)); // potentially tainted
|
|
sink(v9.at(1)); // potentially tainted
|
|
sink(v9.at(x)); // tainted
|
|
}
|
|
|
|
void test_vector_swap() {
|
|
std::vector<int> v1(10), v2(10), v3(10), v4(10);
|
|
|
|
v1.push_back(source());
|
|
v4.push_back(source());
|
|
|
|
sink(v1); // tainted
|
|
sink(v2);
|
|
sink(v3);
|
|
sink(v4); // tainted
|
|
|
|
v1.swap(v2);
|
|
v3.swap(v4);
|
|
|
|
sink(v1); // [FALSE POSITIVE]
|
|
sink(v2); // tainted
|
|
sink(v3); // tainted
|
|
sink(v4); // [FALSE POSITIVE]
|
|
}
|
|
|
|
void test_vector_clear() {
|
|
std::vector<int> v1(10), v2(10), v3(10), v4(10);
|
|
|
|
v1.push_back(source());
|
|
v2.push_back(source());
|
|
v3.push_back(source());
|
|
|
|
sink(v1); // tainted
|
|
sink(v2); // tainted
|
|
sink(v3); // tainted
|
|
sink(v4);
|
|
|
|
v1.clear();
|
|
v2 = v2;
|
|
v3 = v4;
|
|
|
|
sink(v1); // [FALSE POSITIVE]
|
|
sink(v2); // tainted
|
|
sink(v3); // [FALSE POSITIVE]
|
|
sink(v4);
|
|
}
|
|
|
|
struct MyPair
|
|
{
|
|
int a, b;
|
|
};
|
|
|
|
struct MyVectorContainer
|
|
{
|
|
std::vector<int> vs;
|
|
};
|
|
|
|
void test_nested_vectors()
|
|
{
|
|
{
|
|
int aa[10][20] = {0};
|
|
|
|
sink(aa[0][0]);
|
|
aa[0][0] = source();
|
|
sink(aa[0][0]); // tainted
|
|
}
|
|
|
|
{
|
|
std::vector<std::vector<int> > bb(30);
|
|
|
|
bb[0].push_back(0);
|
|
sink(bb[0][0]);
|
|
bb[0][0] = source();
|
|
sink(bb[0][0]); // tainted
|
|
}
|
|
|
|
{
|
|
std::vector<int> cc[40];
|
|
|
|
cc[0].push_back(0);
|
|
sink(cc[0][0]);
|
|
cc[0][0] = source();
|
|
sink(cc[0][0]); // tainted
|
|
}
|
|
|
|
{
|
|
std::vector<MyPair> dd;
|
|
MyPair mp = {0, 0};
|
|
|
|
dd.push_back(mp);
|
|
sink(dd[0].a);
|
|
sink(dd[0].b);
|
|
dd[0].a = source();
|
|
sink(dd[0].a); // tainted [NOT DETECTED]
|
|
sink(dd[0].b);
|
|
}
|
|
|
|
{
|
|
MyVectorContainer ee;
|
|
|
|
ee.vs.push_back(0);
|
|
sink(ee.vs[0]);
|
|
ee.vs[0] = source();
|
|
sink(ee.vs[0]); // tainted
|
|
}
|
|
|
|
{
|
|
std::vector<MyVectorContainer> ff;
|
|
MyVectorContainer mvc;
|
|
|
|
mvc.vs.push_back(0);
|
|
ff.push_back(mvc);
|
|
sink(ff[0].vs[0]);
|
|
ff[0].vs[0] = source();
|
|
sink(ff[0].vs[0]); // tainted [NOT DETECTED]
|
|
}
|
|
}
|
|
|
|
void sink(std::vector<int>::iterator &);
|
|
|
|
typedef int myInt;
|
|
typedef float myFloat;
|
|
|
|
namespace ns_myFloat
|
|
{
|
|
myFloat source();
|
|
}
|
|
|
|
namespace ns_ci_ptr
|
|
{
|
|
const int *source();
|
|
}
|
|
|
|
void sink(std::vector<myFloat> &);
|
|
void sink(std::vector<const int *> &);
|
|
|
|
void test_vector_assign() {
|
|
std::vector<int> v1, v2, v3;
|
|
|
|
v1.assign(100, 0);
|
|
v2.assign(100, ns_int::source());
|
|
v3.push_back(source());
|
|
|
|
sink(v1);
|
|
sink(v2); // tainted
|
|
sink(v3); // tainted
|
|
|
|
{
|
|
std::vector<int> v4, v5, v6;
|
|
std::vector<int>::iterator i1, i2;
|
|
|
|
v4.assign(v1.begin(), v1.end());
|
|
v5.assign(v3.begin(), v3.end());
|
|
i1 = v3.begin();
|
|
i1++;
|
|
i2 = i1;
|
|
i2++;
|
|
v6.assign(i1, i2);
|
|
|
|
sink(v4);
|
|
sink(v5); // tainted
|
|
sink(i1); // tainted
|
|
sink(i2); // tainted
|
|
sink(v6); // tainted
|
|
}
|
|
|
|
{
|
|
std::vector<myInt> v7;
|
|
std::vector<myFloat> v8;
|
|
std::vector<const int *> v9;
|
|
|
|
v7.assign(100, ns_int::source());
|
|
v8.assign(100, ns_myFloat::source());
|
|
v9.assign(100, ns_ci_ptr::source());
|
|
|
|
sink(v7); // tainted
|
|
sink(v8); // tainted
|
|
sink(v9); // tainted
|
|
}
|
|
}
|
|
|
|
void sink(int *);
|
|
|
|
void test_data_more() {
|
|
std::vector<int> v1, v2;
|
|
|
|
v1.push_back(source());
|
|
sink(v1); // tainted
|
|
sink(v1.data()); // tainted
|
|
sink(v1.data()[2]); // tainted
|
|
|
|
*(v2.data()) = ns_int::source();
|
|
sink(v2); // tainted
|
|
sink(v2.data()); // tainted
|
|
sink(v2.data()[2]); // tainted
|
|
}
|
|
|
|
void sink(std::vector<int>::iterator);
|
|
|
|
void test_vector_insert() {
|
|
std::vector<int> a;
|
|
std::vector<int> b;
|
|
std::vector<int> c;
|
|
std::vector<int> d;
|
|
|
|
d.push_back(source());
|
|
|
|
sink(a.insert(a.end(), b.begin(), b.end()));
|
|
sink(a);
|
|
|
|
sink(c.insert(c.end(), d.begin(), d.end())); // tainted
|
|
sink(c); // tainted
|
|
|
|
sink(d.insert(d.end(), a.begin(), a.end())); // tainted
|
|
sink(d); // tainted
|
|
}
|
|
|
|
void test_constructors_more() {
|
|
std::vector<int> v1;
|
|
std::vector<int> v2;
|
|
v2.push_back(source());
|
|
|
|
std::vector<int> v3(v1.begin(), v1.end());
|
|
std::vector<int> v4(v2.begin(), v2.end());
|
|
|
|
sink(v1);
|
|
sink(v2); // tainted
|
|
sink(v3);
|
|
sink(v4); // tainted
|
|
}
|