mirror of
https://github.com/github/codeql.git
synced 2025-12-18 09:43:15 +01:00
77021ae119
We were mixing between things, so this is just to keep things consistent. Even though it's not strictly needed for all queries, it does look nice I think
59 lines
1.2 KiB
Python
59 lines
1.2 KiB
Python
from flask import Flask, request, make_response
|
|
app = Flask(__name__)
|
|
|
|
|
|
import traceback
|
|
|
|
def do_computation():
|
|
raise Exception("Secret info")
|
|
|
|
# BAD
|
|
@app.route('/bad')
|
|
def server_bad():
|
|
try:
|
|
do_computation()
|
|
except Exception:
|
|
return traceback.format_exc() #$ exceptionInfo
|
|
|
|
# BAD
|
|
@app.route('/bad/direct')
|
|
def server_bad_direct():
|
|
try:
|
|
do_computation()
|
|
except Exception as e: #$ exceptionInfo
|
|
return e
|
|
|
|
# BAD
|
|
@app.route('/bad/traceback')
|
|
def server_bad_traceback():
|
|
try:
|
|
do_computation()
|
|
except Exception as e: #$ exceptionInfo
|
|
return e.__traceback__
|
|
|
|
# GOOD
|
|
@app.route('/good')
|
|
def server_good():
|
|
try:
|
|
do_computation()
|
|
except Exception:
|
|
log(traceback.format_exc()) #$ exceptionInfo
|
|
return "An internal error has occurred!"
|
|
|
|
#BAD
|
|
@app.route('/bad/with-flow')
|
|
def server_bad_flow():
|
|
try:
|
|
do_computation()
|
|
except Exception:
|
|
err = traceback.format_exc() #$ exceptionInfo
|
|
return format_error(err)
|
|
|
|
def format_error(msg):
|
|
return "[ERROR] " + msg
|
|
|
|
#Unrelated error
|
|
@app.route('/maybe_xss')
|
|
def maybe_xss():
|
|
return make_response(request.args.get('name', ''))
|