mirror of
https://github.com/github/codeql.git
synced 2026-04-11 18:14:01 +02:00
423d325204
The check for `(unnamed local variable)` is no longer needed, because these variables are now identified as being compiler generated.
24 lines
829 B
Plaintext
24 lines
829 B
Plaintext
/**
|
|
* @name Declaration hides variable
|
|
* @description A local variable hides another local variable from a surrounding scope. This may be confusing. Consider renaming one of the variables.
|
|
* @kind problem
|
|
* @problem.severity recommendation
|
|
* @precision high
|
|
* @id cpp/declaration-hides-variable
|
|
* @tags maintainability
|
|
* readability
|
|
*/
|
|
|
|
import cpp
|
|
import Best_Practices.Hiding.Shadowing
|
|
|
|
from LocalVariable lv1, LocalVariable lv2
|
|
where
|
|
shadowing(lv1, lv2) and
|
|
not lv1.isCompilerGenerated() and
|
|
not lv2.isCompilerGenerated() and
|
|
not lv1.getParentScope().(BlockStmt).isInMacroExpansion() and
|
|
not lv2.getParentScope().(BlockStmt).isInMacroExpansion()
|
|
select lv1, "Variable " + lv1.getName() + " hides another variable of the same name (on $@).", lv2,
|
|
"line " + lv2.getLocation().getStartLine().toString()
|